Fix explore searching (#17289)

This closes #17285. The `explore` searching should now work again. I
also fixed a bug with `e` and `t` and they should work better now too.

## Release notes summary - What our users need to know
N/A

## Tasks after submitting
N/A

Author: fdncred

crates/nu-explore/src/explore/pager/mod.rs

@@ -853,6 +853,24 @@ fn handle_general_key_events2<V>(
                 }
             }
         }
+        KeyCode::Char('N') => {
+            if !search.search_results.is_empty() {
+                if search.buf_cmd_input.is_empty() {
+                    search.buf_cmd_input.clone_from(&search.buf_cmd);
+                }
+
+                if search.search_index == 0 {
+                    search.search_index = search.search_results.len() - 1;
+                } else {
+                    search.search_index -= 1;
+                }
+
+                let pos = search.search_results[search.search_index];
+                if let Some(view) = view {
+                    view.show_data(pos);
+                }
+            }
+        }
         _ => {}
     }
 }
@@ -882,6 +900,19 @@ fn search_input_key_event(
             buf.buf_cmd.clone_from(&buf.buf_cmd_input);
             buf.is_search_input = false;
 
+            if let Some(view) = view
+                && !buf.buf_cmd.is_empty()
+            {
+                let data = view.collect_data().into_iter().map(|(text, _)| text);
+                buf.search_results = search_pattern(data, &buf.buf_cmd, buf.is_reversed);
+                buf.search_index = 0;
+
+                if !buf.search_results.is_empty() {
+                    let pos = buf.search_results[buf.search_index];
+                    view.show_data(pos);
+                }
+            }
+
             true
         }
         KeyCode::Backspace => {

crates/nu-explore/src/explore/views/record/mod.rs

@@ -16,9 +16,9 @@ use super::{
 };
 use anyhow::Result;
 use crossterm::event::{KeyCode, KeyEvent};
-use nu_color_config::StyleComputer;
+use nu_color_config::{StyleComputer, TextStyle};
 use nu_protocol::{
-    Config, Value,
+    Config, Record, Value,
     engine::{EngineState, Stack},
 };
 use ratatui::{layout::Rect, widgets::Block};
@@ -284,13 +284,111 @@ impl View for RecordView {
         }
     }
 
+    fn collect_data(&self) -> Vec<NuText> {
+        let layer = self.get_top_layer();
+        let mut texts = Vec::new();
+
+        // Add headers
+        for name in &layer.column_names {
+            texts.push((name.clone(), TextStyle::default()));
+        }
+
+        // Add data
+        for row in &layer.record_values {
+            for value in row {
+                let text = value.to_abbreviated_string(&Config::default());
+                let text = strip_string(&text);
+                texts.push((text, TextStyle::default()));
+            }
+        }
+
+        texts
+    }
+
+    fn show_data(&mut self, pos: usize) -> bool {
+        let layer = self.get_top_layer();
+        let num_headers = layer.column_names.len();
+
+        if pos < num_headers {
+            // Header
+            let column = pos;
+            let row = 0;
+            self.get_top_layer_mut()
+                .cursor
+                .set_window_start_position(row, column);
+            return true;
+        } else {
+            let data_pos = pos - num_headers;
+            let mut i = 0;
+            for (data_row, cells) in layer.record_values.iter().enumerate() {
+                if data_pos >= i && data_pos < i + cells.len() {
+                    let column = data_pos - i;
+                    let row = data_row + 1; // +1 for header row
+                    self.get_top_layer_mut()
+                        .cursor
+                        .set_window_start_position(row, column);
+                    return true;
+                }
+                i += cells.len();
+            }
+        }
+
+        false
+    }
+
     fn update(&mut self, _info: &mut ViewInfo) -> bool {
         false
     }
 
     fn exit(&mut self) -> Option<Value> {
-        None
+        Some(build_last_value(self))
+    }
+}
+
+fn build_last_value(v: &RecordView) -> Value {
+    if v.mode == UIMode::Cursor {
+        v.get_current_value().clone()
+    } else if v.get_top_layer().count_rows() < 2 {
+        build_table_as_record(v)
+    } else {
+        build_table_as_list(v)
+    }
+}
+
+fn build_table_as_list(v: &RecordView) -> Value {
+    let layer = v.get_top_layer();
+
+    let vals = layer
+        .record_values
+        .iter()
+        .map(|vals| {
+            let record = layer
+                .column_names
+                .iter()
+                .cloned()
+                .zip(vals.iter().cloned())
+                .collect();
+            Value::record(record, NuSpan::unknown())
+        })
+        .collect();
+
+    Value::list(vals, NuSpan::unknown())
+}
+
+fn build_table_as_record(v: &RecordView) -> Value {
+    let layer = v.get_top_layer();
+
+    let mut record = Record::new();
+    if let Some(row) = layer.record_values.first() {
+        record = layer
+            .column_names
+            .iter()
+            .cloned()
+            .zip(row.iter().cloned())
+            .collect();
     }
+
+    Value::record(record, NuSpan::unknown())
 }
 
 fn get_element_info(
@@ -583,11 +681,7 @@ fn transpose_from(layer: &mut RecordLayer) {
     let count_rows = layer.record_values.len();
     let count_columns = layer.column_names.len();
 
-    if let Some(data) = &mut layer.record_text {
-        pop_first_column(data);
-        *data = _transpose_table(data, count_rows, count_columns - 1);
-    }
-
+    // Extract the original column names from the first column
     let headers = pop_first_column(&mut layer.record_values);
     let headers = headers
         .into_iter()
@@ -601,40 +695,36 @@ fn transpose_from(layer: &mut RecordLayer) {
 
     layer.record_values = data;
     layer.column_names = headers;
+    // Invalidate the text cache so it gets regenerated with the new structure
+    layer.record_text = None;
+}
+
+fn pop_first_column<T>(values: &mut [Vec<T>]) -> Vec<T>
+where
+    T: Default + Clone,
+{
+    let mut data = vec![T::default(); values.len()];
+    for (row, values) in values.iter_mut().enumerate() {
+        data[row] = values.remove(0);
+    }
+
+    data
 }
 
 fn transpose_to(layer: &mut RecordLayer) {
     let count_rows = layer.record_values.len();
     let count_columns = layer.column_names.len();
 
-    if let Some(data) = &mut layer.record_text {
-        *data = _transpose_table(data, count_rows, count_columns);
-        for (column, column_name) in layer.column_names.iter().enumerate() {
-            let value = (column_name.to_owned(), Default::default());
-            data[column].insert(0, value);
-        }
-    }
-
     let mut data = _transpose_table(&layer.record_values, count_rows, count_columns);
     for (column, column_name) in layer.column_names.iter().enumerate() {
         let value = Value::string(column_name, NuSpan::unknown());
         data[column].insert(0, value);
     }
 
     layer.record_values = data;
-    layer.column_names = (1..count_rows + 1 + 1).map(|i| i.to_string()).collect();
-}
-
-fn pop_first_column<T>(values: &mut [Vec<T>]) -> Vec<T>
-where
-    T: Default + Clone,
-{
-    let mut data = vec![T::default(); values.len()];
-    for (row, values) in values.iter_mut().enumerate() {
-        data[row] = values.remove(0);
-    }
-
-    data
+    layer.column_names = (1..=count_rows + 1).map(|i| i.to_string()).collect();
+    // Invalidate the text cache so it gets regenerated with the new structure
+    layer.record_text = None;
 }
 
 fn _transpose_table<T>(values: &[Vec<T>], count_rows: usize, count_columns: usize) -> Vec<Vec<T>>