Skip to content

Commit 71b98f9

Browse files
authored
Fix dataframe python example (#1593)
Also: - tidy/clarify contributing doc - bump micromatch to address npm audit warning
1 parent fdb5c24 commit 71b98f9

File tree

3 files changed

+29
-29
lines changed

3 files changed

+29
-29
lines changed

CONTRIBUTING.md

Lines changed: 21 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,18 @@ These pages are generated automatically from the internal help in each command's
1212
This website is based on VuePress.
1313

1414
## Getting started
15+
1516
### One-time Setup
1617

17-
1. First of all, make sure you have installed `node.js`(v18.12.0 or above)
18-
1. Create a fork of the (website repository)(https://github.com/nushell/nushell.github.io)
18+
1. [Fork the website repository](https://github.com/nushell/nushell.github.io/fork)
1919
1. Clone the doc repo locally:
2020

2121
```nu
2222
git clone [email protected]:nushell/nushell.github.io.git nu-docs
2323
```
2424

25-
26-
1. [Install Node.js](https://nodejs.org/en/download/), the minimum version required: v18.12.0
27-
2. Run `npm install` in the root of the local repo after cloning to install the required dependencies for the dev server. This will also be necessary if any dependencies change.
25+
1. [Install Node.js](https://nodejs.org/en/download/) (minimum version required: v18.12.0)
26+
1. Run `npm install` in the root of the local repo after cloning to install the required dependencies for the dev server. This will also be necessary if any dependencies change.
2827

2928
### For each group of changes
3029

@@ -41,9 +40,9 @@ This website is based on VuePress.
4140
```
4241

4342
1. If you're adding a new page to the book, to make it appear, put it also to `.vuepress/configs/sidebar/{locale}.ts`.
44-
2. Make changes
45-
3. Verify your local changes render correctly using a web browser pointing to the local dev server site
46-
4. Commit and push your changes
43+
1. Make changes
44+
1. Verify your local changes render correctly by opening <http://localhost:8080/> in a web browser and navigating to the new or changed pages
45+
1. Commit and push your changes
4746

4847
```nu
4948
git commit -m "Commit Message"
@@ -52,56 +51,56 @@ This website is based on VuePress.
5251

5352
(Where `my_changes` is the current branch)
5453

55-
5. Create a pull request in this GitHub repo
54+
1. Create a pull request in this GitHub repo
5655

5756
## Enabling a Preview URL From Your Fork
5857

5958
Just enable GitHub actions in your repo settings. That's all! It will start deploying the next time you push to `main`.
6059

61-
6260
### Display Nu Code Snippets With Syntax Highlighting
6361

64-
To display Nushell code snippets with syntax highlighting support you can wrap the Nu codes with \```nu \``` or \```nushell \```, for example:
62+
To display Nushell code snippets with syntax highlighting support you can wrap the Nu codes with `` ```nu ``` `` or `` ```nushell ``` ``, for example:
6563

64+
````plain
6665
```nu
6766
# List the top five largest files
6867
ls | where type == file | sort-by -r size | first 5
6968
```
69+
````
7070

71-
The preferred form for consistency is \```nu
71+
The preferred form for consistency is `` ```nu ``.
7272

7373
## Translation Guide
7474

7575
Follow the steps above for each group of translations.
7676

7777
### Adding to or updating existing translations
7878

79-
* Check outdated translations. A helper script is provided for this. From the repository root, run:
79+
Check outdated translations. A helper script is provided for this. From the repository root, run:
8080

8181
```nu
8282
nu tools/i18n.nu outdated zh-CN
8383
```
8484

85-
This will provide a list of all files that have been changed or added since the last translation update for the specified locale.
86-
85+
This will provide a list of all files that have been changed or added since the last translation update for the specified locale.
8786

8887
### Creating a new translation
8988

9089
1. Add a book dir for the specified locale in the docs' root folder, say `zh-CN`.
9190
1. Create a `book` child folder for all your translated documents and a README.md for the home page of your locale
92-
4. Modify the VuePress config file `.vuepress/config.js` and add `zh-CN` related configs.
91+
1. Modify the VuePress config file `.vuepress/config.js` and add `zh-CN` related configs.
9392

94-
Here is an example [commit](https://github.com/nushell/nushell.github.io/commit/46d1672) for reference.
93+
Here is an [example commit](https://github.com/nushell/nushell.github.io/commit/46d1672) for reference.
9594

96-
5. Add a `README.md` in the `book` dir which will be the default introduction page of Nushell.
95+
1. Add a `README.md` in the `book` dir which will be the default introduction page of Nushell.
9796

9897
::: warning Important
9998
Please **DO NOT** translate the file name of the docs.
10099
:::
101100

102-
6. Run `npm run dev`, then open **http://localhost:8080/** in your browser
101+
1. Run `npm run dev`, then open <http://localhost:8080/> in your browser
103102
1. Switch to the language you are going to translate into, and you will see the introduction page you have just created. You can translate the docs and save them to get a preview in the browser.
104103

105-
7. Update the `i18n-meta.json` file by filling in the locale value of the doc you have just finished. It's recommended to use `commit_id@author` or simply a `commit_id` to indicate your translation end to the specified commit.
106-
8. Commit your changes. It's recommended to squash all your commits in one commit with a commit message like this: `Translate your_doc_file.md to zh-CN from commit: f3dc86d3d`;
107-
9. Push your changes as documented above
104+
1. Update the `i18n-meta.json` file by filling in the locale value of the doc you have just finished. It's recommended to use `commit_id@author` or simply a `commit_id` to indicate your translation end to the specified commit.
105+
1. Commit your changes. It's recommended to squash all your commits in one commit with a commit message like this: `Translate your_doc_file.md to zh-CN from commit: f3dc86d3d`;
106+
1. Push your changes as documented above

book/dataframes.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Dataframes
22

33
::: warning Important!
4-
This feature requires the Polars plugin. See the the
4+
This feature requires the Polars plugin. See the
55
[Plugins Chapter](plugins.md) to learn how to install it.
66

77
To test that this plugin is properly installed, run `help polars`.
@@ -61,7 +61,7 @@ The dataset has 5 columns and 5,429,252 rows. We can check that by using the
6161
```
6262

6363
::: tip
64-
As of nushell 0.97, `polars open` will open as a lazy dataframe instead of a eager dataframe.
64+
As of nushell 0.97, `polars open` will open as a lazy dataframe instead of a eager dataframe.
6565
To open as an eager dataframe, use the `--eager` flag.
6666
:::
6767

@@ -135,7 +135,7 @@ And the result from the benchmark is:
135135

136136
```nu
137137
bench -n 10 --pretty {
138-
python load.py | null
138+
python load.py | complete | null
139139
}
140140
```
141141

package-lock.json

Lines changed: 5 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)