From c9a4fdc7d7c1bdaacf760b5f524ee32d64224826 Mon Sep 17 00:00:00 2001 From: Jan Klass Date: Mon, 18 Nov 2024 18:25:12 +0100 Subject: [PATCH] Drop experimental label from display_output hook As per comment https://github.com/nushell/nushell/pull/14361#issuecomment-2483400412 it's not clear what "experimental" would mean, the hook was introduced two years ago and has been stable since, and in #14361 there is a discussion about the hooks behavior but no indication that it would be dropped. Dropping the experimental label makes it more obvious that the hook is here to stay. If its behavior will change, it can be documented like usual in release breaking change notes (which would make sense anyway). As a drive-by text form fixup, drop the period from the last two list items. None of the other list items end in a period, which matches common form for [simple] lists. --- book/hooks.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/book/hooks.md b/book/hooks.md index a2e63b5fddb..55b655bef85 100644 --- a/book/hooks.md +++ b/book/hooks.md @@ -8,8 +8,8 @@ Currently, we support these types of hooks: - `pre_prompt` : Triggered before the prompt is drawn - `pre_execution` : Triggered before the line input starts executing - `env_change` : Triggered when an environment variable changes -- `display_output` : A block that the output is passed to (experimental). -- `command_not_found` : Triggered when a command is not found. +- `display_output` : A block that the output is passed to +- `command_not_found` : Triggered when a command is not found To make it clearer, we can break down Nushell's execution cycle. The steps to evaluate one line in the REPL mode are as follows: