Skip to content

Conversation

@NotTheDr01ds
Copy link
Contributor

  • Disables the PrismJS highlighter entirely (I hope), setting Shiki as the highlighter for both VuePress and the theme.

  • CSV was apparently getting parsed through Prism previously, so this also adds the csv language to the Shiki config

  • And this changes the Shiki code-block theme from dark-plus to vitesse-dark. This does not appear to change any nu/nushell syntax highlighting, but it does enable proper ansi coloring.

This might finally explain why line-numbers were being applied by both Shiki and PrismJS previously.

@NotTheDr01ds NotTheDr01ds requested a review from hustcer December 28, 2024 04:56
@hustcer hustcer merged commit 44569f6 into nushell:main Dec 28, 2024
2 checks passed
@hustcer
Copy link
Contributor

hustcer commented Dec 28, 2024

Thanks for the quick fix

@fdncred
Copy link
Contributor

fdncred commented Dec 28, 2024

This does not appear to change any nu/nushell syntax highlighting,

definitely does for me. I don't recall green and pumpkin colored text like this. is there something closer to dark-plus that we can use?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants