feat: add EditCommand::MoveLineUp and EditCommand::MoveLineDown

This allows us to select multiple lines using shift + up/down keys (or j/k keys in visual mode)

Author: Juhan280

src/core_editor/editor.rs

@@ -64,6 +64,8 @@ impl Editor {
             EditCommand::MoveToPosition { position, select } => {
                 self.move_to_position(*position, *select)
             }
+            EditCommand::MoveLineUp { select } => self.move_up(*select),
+            EditCommand::MoveLineDown { select } => self.move_down(*select),
             EditCommand::MoveLeft { select } => self.move_left(*select),
             EditCommand::MoveRight { select } => self.move_right(*select),
             EditCommand::MoveWordLeft { select } => self.move_word_left(*select),
@@ -619,6 +621,16 @@ impl Editor {
         self.line_buffer.insert_str(string);
     }
 
+    fn move_up(&mut self, select: bool) {
+        self.update_selection_anchor(select);
+        self.line_buffer.move_line_up();
+    }
+
+    fn move_down(&mut self, select: bool) {
+        self.update_selection_anchor(select);
+        self.line_buffer.move_line_down();
+    }
+
     fn move_left(&mut self, select: bool) {
         self.update_selection_anchor(select);
         self.line_buffer.move_left();

src/edit_mode/keybindings.rs

@@ -242,6 +242,16 @@ pub fn add_common_selection_bindings(kb: &mut Keybindings) {
     use KeyCode as KC;
     use KeyModifiers as KM;
 
+    kb.add_binding(
+        KM::SHIFT,
+        KC::Up,
+        edit_bind(EC::MoveLineUp { select: true }),
+    );
+    kb.add_binding(
+        KM::SHIFT,
+        KC::Down,
+        edit_bind(EC::MoveLineDown { select: true }),
+    );
     kb.add_binding(
         KM::SHIFT,
         KC::Left,

src/edit_mode/vi/motion.rs

@@ -179,16 +179,22 @@ impl Motion {
                     select: select_mode,
                 }]),
             ]))],
-            Motion::Up => vec![ReedlineOption::Event(ReedlineEvent::UntilFound(vec![
-                ReedlineEvent::MenuUp,
-                ReedlineEvent::Up,
-                // todo: add EditCommand::MoveLineUp
-            ]))],
-            Motion::Down => vec![ReedlineOption::Event(ReedlineEvent::UntilFound(vec![
-                ReedlineEvent::MenuDown,
-                ReedlineEvent::Down,
-                // todo: add EditCommand::MoveLineDown
-            ]))],
+            Motion::Up => vec![if select_mode {
+                ReedlineOption::Edit(EditCommand::MoveLineUp { select: true })
+            } else {
+                ReedlineOption::Event(ReedlineEvent::UntilFound(vec![
+                    ReedlineEvent::MenuUp,
+                    ReedlineEvent::Up,
+                ]))
+            }],
+            Motion::Down => vec![if select_mode {
+                ReedlineOption::Edit(EditCommand::MoveLineDown { select: true })
+            } else {
+                ReedlineOption::Event(ReedlineEvent::UntilFound(vec![
+                    ReedlineEvent::MenuDown,
+                    ReedlineEvent::Down,
+                ]))
+            }],
             Motion::NextWord => vec![ReedlineOption::Edit(EditCommand::MoveWordRightStart {
                 select: select_mode,
             })],

src/engine.rs

@@ -1662,7 +1662,7 @@ impl Reedline {
             // If we're at the top, move to previous history
             self.previous_history();
         } else {
-            self.editor.move_line_up();
+            self.run_edit_commands(&[EditCommand::MoveLineUp { select: false }]);
         }
     }
 
@@ -1672,7 +1672,7 @@ impl Reedline {
             // If we're at the top, move to previous history
             self.next_history();
         } else {
-            self.editor.move_line_down();
+            self.run_edit_commands(&[EditCommand::MoveLineDown { select: false }]);
         }
     }
 

src/enums.rs

@@ -112,6 +112,18 @@ pub enum EditCommand {
         select: bool,
     },
 
+    /// Move one line up
+    MoveLineUp {
+        /// Select the text between the current cursor position and destination
+        select: bool,
+    },
+
+    /// Move one line down
+    MoveLineDown {
+        /// Select the text between the current cursor position and destination
+        select: bool,
+    },
+
     /// Move one character to the left
     MoveLeft {
         /// Select the text between the current cursor position and destination
@@ -482,6 +494,8 @@ impl Display for EditCommand {
             EditCommand::MoveToLineEnd { .. } => {
                 write!(f, "MoveToLineEnd Optional[select: <bool>]")
             }
+            EditCommand::MoveLineUp { .. } => write!(f, "MoveLineUp Optional[select: <bool>]"),
+            EditCommand::MoveLineDown { .. } => write!(f, "MoveLineDown Optional[select: <bool>]"),
             EditCommand::MoveLeft { .. } => write!(f, "MoveLeft Optional[select: <bool>]"),
             EditCommand::MoveRight { .. } => write!(f, "MoveRight Optional[select: <bool>]"),
             EditCommand::MoveWordLeft { .. } => write!(f, "MoveWordLeft Optional[select: <bool>]"),
@@ -613,6 +627,8 @@ impl EditCommand {
             | EditCommand::MoveToLineEnd { select, .. }
             | EditCommand::MoveToLineNonBlankStart { select, .. }
             | EditCommand::MoveToPosition { select, .. }
+            | EditCommand::MoveLineUp { select, .. }
+            | EditCommand::MoveLineDown { select, .. }
             | EditCommand::MoveLeft { select, .. }
             | EditCommand::MoveRight { select, .. }
             | EditCommand::MoveWordLeft { select, .. }