Disable planner conflicts in non-current years (#3752)

Author: leslieyip02

website/src/views/planner/PlannerSemester.test.tsx

@@ -0,0 +1,81 @@
+import { mount } from 'enzyme';
+import { DragDropContextProps, DraggableProps, DroppableProps } from 'react-beautiful-dnd';
+import { Provider } from 'react-redux';
+import { Router } from 'react-router-dom';
+
+import { PlannerModuleInfo, Conflict } from 'types/planner';
+import configureStore from 'bootstrapping/configure-store';
+import createHistory from 'test-utils/createHistory';
+import config from 'config';
+import PlannerSemester from './PlannerSemester';
+import plannerModuleStyles from './PlannerModule.scss';
+
+jest.mock('react-beautiful-dnd', () => ({
+  Droppable: ({ children }: DroppableProps) => children({} as any, {} as any),
+  Draggable: ({ children }: DraggableProps) => children({} as any, {} as any, {} as any),
+  DragDropContext: ({ children }: DragDropContextProps) => children,
+}));
+
+function makePlannerSemester(year: string, semester: number, modules: PlannerModuleInfo[]) {
+  const { store } = configureStore();
+  const { history } = createHistory();
+
+  const addModule = jest.fn();
+  const removeModule = jest.fn();
+  const addCustomData = jest.fn();
+  const setPlaceholderModule = jest.fn();
+  const addModuleToTimetable = jest.fn();
+
+  return mount(
+    <Provider store={store}>
+      <Router history={history}>
+        <PlannerSemester
+          year={year}
+          semester={semester}
+          modules={modules}
+          addModule={addModule}
+          removeModule={removeModule}
+          addCustomData={addCustomData}
+          setPlaceholderModule={setPlaceholderModule}
+          addModuleToTimetable={addModuleToTimetable}
+        />
+      </Router>
+    </Provider>,
+  );
+}
+
+test('should show conflicts for current year', () => {
+  const conflict: Conflict = {
+    type: 'semester',
+    semestersOffered: [],
+  };
+
+  const modules: PlannerModuleInfo[] = [
+    {
+      id: '0',
+      moduleCode: 'UTC1702G',
+      conflict,
+    },
+  ];
+
+  const wrapper = makePlannerSemester(config.academicYear, 1, modules);
+  expect(wrapper.find(`.${plannerModuleStyles.conflicts}`).exists()).toBe(true);
+});
+
+test('should not show conflicts for non-current years', () => {
+  const conflict: Conflict = {
+    type: 'semester',
+    semestersOffered: [],
+  };
+
+  const modules: PlannerModuleInfo[] = [
+    {
+      id: '0',
+      moduleCode: 'UTC1702G',
+      conflict,
+    },
+  ];
+
+  const wrapper = makePlannerSemester('2015/2016', 1, modules);
+  expect(wrapper.find(`.${plannerModuleStyles.conflicts}`).exists()).toBe(false);
+});

website/src/views/planner/PlannerSemester.tsx

@@ -89,7 +89,7 @@ const PlannerSemester: React.FC<Props> = ({
         moduleTitle={getModuleTitle(plannerModule)}
         examDate={showExamDate && moduleInfo ? getExamDate(moduleInfo, semester) : null}
         moduleCredit={showModuleMeta ? getModuleCredit(plannerModule) : null}
-        conflict={conflict}
+        conflict={year === config.academicYear ? conflict : null}
         semester={semester}
         isInTimetable={isInTimetable}
         removeModule={removeModule}