fix(optimiser): read embedded venues.json instead of fetching (#4142)

Author: leslieyip02

website/api/optimiser/.gitignore

@@ -0,0 +1 @@
+_constants/venues.json

website/api/optimiser/_client/client.go

@@ -4,27 +4,18 @@ import (
 	"encoding/json"
 	"fmt"
 	"io"
+	"log"
 	"net/http"
 
-	"github.com/nusmodifications/nusmods/website/api/optimiser/_constants"
-	"github.com/nusmodifications/nusmods/website/api/optimiser/_models"
+	constants "github.com/nusmodifications/nusmods/website/api/optimiser/_constants"
+	models "github.com/nusmodifications/nusmods/website/api/optimiser/_models"
 )
 
 func GetVenues() (map[string]models.Location, error) {
 	venues := make(map[string]models.Location)
-	url := constants.VenuesURL
-	res, err := http.Get(url)
-	if err != nil {
-		return nil, err
-	}
-	defer res.Body.Close()
-
-	body, err := io.ReadAll(res.Body)
-	if err != nil {
-		return nil, err
-	}
-	err = json.Unmarshal(body, &venues)
+	err := json.Unmarshal(constants.VenuesJson, &venues)
 	if err != nil {
+		log.Printf("unable to load venues.json: %v", err)
 		return nil, err
 	}
 

website/api/optimiser/_constants/constants.go

@@ -1,5 +1,9 @@
 package constants
 
+import (
+	_ "embed"
+)
+
 // Ensure in sync with all E-Venues in NUSMods
 var E_Venues = map[string]bool{
 	"E-Learn_A":  true,
@@ -28,7 +32,8 @@ var LessonTypeAbbrev = map[string]string{
 	"WORKSHOP":                   "WS",
 }
 
-var VenuesURL = "https://github.nusmods.com/venues"
+//go:embed venues.json
+var VenuesJson []byte
 
 var ModulesURL = "https://api.nusmods.com/v2/%s/modules/%s.json"
 

website/package.json

@@ -5,8 +5,9 @@
   "scripts": {
     "start": "cross-env NODE_ENV=development webpack serve --config webpack/webpack.config.dev.js",
     "start:export": "cross-env NODE_ENV=development OPEN_BROWSER=0 webpack serve --config webpack/webpack.config.timetable-only.js --port 8081",
-    "start:optimiser": "cd api/optimiser/_test && go run main.go",
-    "build": "cross-env NODE_ENV=production node scripts/build",
+    "start:optimiser": "yarn prepare:optimiser && cd api/optimiser/_test && go run main.go",
+    "prepare:optimiser": "cp src/data/venues.json api/optimiser/_constants",
+    "build": "yarn prepare:optimiser && cross-env NODE_ENV=production node scripts/build",
     "rsync": "rsync -avu dist/",
     "rsync:export": "rsync -avu --delete-after dist-timetable/",
     "promote-staging": "bash scripts/promote-staging.sh",

website/vercel.json

@@ -3,6 +3,9 @@
     "api/**/*.ts": {
       "excludeFiles": "./tsconfig.json",
       "includeFiles": "{./api/tsconfig.json,./src/serverless/*.xml}"
+    },
+    "api/**/*.go": {
+      "includeFiles": "./api/optimiser/_constants/venues.json"
     }
   },
   "headers": [