Skip to content

Commit 71554a1

Browse files
committed
Revert "chore(all): migrate to AY25/26"
This reverts commit c007533.
1 parent c007533 commit 71554a1

File tree

9 files changed

+12
-61
lines changed

9 files changed

+12
-61
lines changed

MAINTENANCE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Create a new issue on GitHub with this checklist after the finals every semester
66

77
- [ ] Update academic year and semester in `website/src/config/app-config.json`, and add current academic year to archive years
88
- [ ] In `app-config.json`, update `examAvailability` to include only the semesters where exam information is available
9-
- [ ] Update `website/src/data/holidays.json` with latest holiday data from academic calendar
9+
- [ ] Update with next year's holiday data from https://github.com/rjchow/singapore_public_holidays and delete old data, then run `scripts/holidays-csv-to-json.js`
1010
- [ ] Update `website/src/data/academic-calendar.json` with data for the new academic year
1111
- [ ] Add announcement to website
1212
- [ ] Update academic year in `scrapers/nus-v2/src/config.ts`

scrapers/nus-v2/src/config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ const config: Config = {
4444
apiConcurrency: env.apiConcurrency || 5,
4545

4646
// Other config
47-
academicYear: '2025/2026',
47+
academicYear: '2024/2025',
4848
dataPath: path.resolve(__dirname, '../data'),
4949
};
5050

website/scripts/holidays/2025_singapore_holidays.csv

Lines changed: 0 additions & 11 deletions
This file was deleted.

website/scripts/holidays/2026_singapore_holidays.csv

Lines changed: 0 additions & 12 deletions
This file was deleted.

website/src/actions/__snapshots__/moduleBank.test.ts.snap

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -98,18 +98,6 @@ exports[`fetchAllModuleArchive should return multiple request actions 1`] = `
9898
"type": "FETCH_ARCHIVE_MODULE",
9999
},
100100
],
101-
[
102-
{
103-
"meta": {
104-
"API_REQUEST": "FETCH_ARCHIVE_MODULE_CS1010S_2024/2025",
105-
"academicYear": "2024/2025",
106-
},
107-
"payload": {
108-
"url": "test://MOCK_MOD_DETAILS_URL/CS1010S/2024/2025",
109-
},
110-
"type": "FETCH_ARCHIVE_MODULE",
111-
},
112-
],
113101
]
114102
`;
115103

website/src/config/app-config.json

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
{
22
"brandName": "NUSMods",
33
"defaultDescription": "NUSMods is a timetable builder and knowledge platform, providing students with a better way to plan their school timetable and useful module-related information that are community-driven.",
4-
"academicYear": "2025/2026",
4+
"academicYear": "2024/2025",
55
"apiBaseUrl": "https://api.nusmods.com",
66
"elasticsearchBaseUrl": "https://nusmods-search.es.ap-southeast-1.aws.found.io:9243",
7-
"semester": 1,
7+
"semester": 2,
88
"disqusShortname": "nusmods-prod",
99
"venueFeedbackApi": "https://nusmods-venue-github-hook.mods.workers.dev",
1010
"moduleErrorApi": "https://nusmods-module-error-reporting.mods.workers.dev",
@@ -16,8 +16,7 @@
1616
"2020/2021",
1717
"2021/2022",
1818
"2022/2023",
19-
"2023/2024",
20-
"2024/2025"
19+
"2023/2024"
2120
],
2221
"examAvailability": [
2322
1,
@@ -49,4 +48,4 @@
4948
"twitter": "https://twitter.com/nusmods",
5049
"telegram": "https://t.me/NUSMods"
5150
}
52-
}
51+
}

website/src/data/academic-calendar.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,5 @@
5454
"2": { "start": [2025, 1, 13] },
5555
"3": { "start": [2025, 5, 12] },
5656
"4": { "start": [2025, 6, 23] }
57-
},
58-
"2025/2026": {
59-
"1": { "start": [2025, 8, 11] },
60-
"2": { "start": [2026, 1, 12] },
61-
"3": { "start": [2026, 5, 11] },
62-
"4": { "start": [2026, 6, 22] }
6357
}
6458
}

website/src/data/holidays.json

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -69,13 +69,7 @@
6969
"2025-06-07",
7070
"2025-08-09",
7171
"2025-10-20",
72+
"2025-10-21",
7273
"2025-12-25",
73-
"2026-01-01",
74-
"2026-02-17",
75-
"2026-02-18",
76-
"2026-03-21",
77-
"2026-04-03",
78-
"2026-05-01",
79-
"2026-05-27",
80-
"2026-06-01"
81-
]
74+
"2026-01-01"
75+
]

website/src/views/components/notfications/Announcements.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ const enableAnnouncements = true;
1717
* dismissible, set the key to null. Otherwise, set it to a string.
1818
*
1919
* Previous keys:
20-
* - 'ay202526-new-data' - AY2025/26 data is available
2120
* - 'ay202425-new-data' - AY2024/25 data is available
2221
* - 'ay202324-new-data' - AY2023/24 data is available
2322
* - 'ay202223-new-data' - AY2022/23 data is available
@@ -32,7 +31,7 @@ const enableAnnouncements = true;
3231
* - 'ay201819-new-data' - AY2018/19 data is available
3332
* - 'ay201819-s2-new-data' - S2 data available
3433
*/
35-
const key = announcementKey('ay202526-new-data');
34+
const key = announcementKey('ay202425-new-data');
3635

3736
export const isNewCourseDataAnnoucement = () => {
3837
if (key) {
@@ -68,9 +67,9 @@ const Announcements = memo(() => {
6867
<Heart className={styles.backgroundIcon} />
6968

7069
<div className={styles.body}>
71-
<h3>AY2025/26 courses now available!</h3>
70+
<h3>AY2024/25 courses now available!</h3>
7271
<p className={styles.bodyElement}>
73-
NUSMods now has AY2025/26 course information available. The data is accurate but subject
72+
NUSMods now has AY2024/25 course information available. The data is accurate but subject
7473
to changes.
7574
</p>
7675
<p className={styles.bodyElement}>

0 commit comments

Comments
 (0)