Skip to content

Commit 9159686

Browse files
tankh99ravern
andauthored
fix(timetable): border-radius gap difference (#3401)
* Fix border-radius gap issue with Timetable - Updated Timetable Cell's border-radius to be the same as Timetable's border-radius to fix the border-gap issue * Created new style: timetable-border-radius in Timetable.scss .days class in Timetable.scss and .clickable class in Timetable.scss now reference from this new style * Move variables to variables.scss --------- Co-authored-by: Ravern Koh <[email protected]>
1 parent 99da62b commit 9159686

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

website/src/views/timetable/Timetable.scss

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
@import './_variables.scss';
22

3-
$timetable-min-width: $timetable-row-height * 16;
4-
53
.container {
64
min-width: $timetable-min-width;
75
background: var(--body-bg); // For timetable export
@@ -22,7 +20,7 @@ $timetable-min-width: $timetable-row-height * 16;
2220
margin: 0;
2321
border: $timetable-border;
2422
border-left-width: 0;
25-
border-radius: $btn-border-radius;
23+
border-radius: $timetable-border-radius;
2624

2725
@include vertical-mode {
2826
display: flex;

website/src/views/timetable/TimetableCell.scss

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
$cell-padding: 0.3rem;
44
$cell-opacity: 0.5;
5-
$cell-border-radius: 6px;
65

76
.baseCell {
87
// Flex to ensure cell content sticks to top, because browsers tend to
@@ -45,7 +44,7 @@ $cell-border-radius: 6px;
4544
}
4645

4746
.clickable {
48-
border-radius: $cell-border-radius;
47+
border-radius: $timetable-border-radius;
4948
cursor: pointer;
5049
}
5150

website/src/views/timetable/_variables.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
@import '~styles/utils/modules-entry.scss';
22

33
$timetable-border: 1px solid var(--gray-lighter);
4+
$timetable-border-radius: 0.25em;
45

56
$timetable-right-padding: 2vw;
67
$timetable-day-h-size: 3.5rem;
@@ -9,3 +10,5 @@ $timetable-day-v-size: 2.5rem;
910

1011
$timetable-row-height: 3.6rem;
1112
$timetable-col-width: 4rem;
13+
14+
$timetable-min-width: $timetable-row-height * 16;

0 commit comments

Comments
 (0)