fix(GlobalSearch): navigate to Venues when clicking "View All" venues (#3477)

Author: zwliew

website/src/types/views.ts

@@ -11,7 +11,7 @@ export type ComponentMap = {
 };
 
 /* layout/GlobalSearch */
-export type ResultType = 'VENUE' | 'MODULE' | 'SEARCH';
+export type SearchResultType = 'VENUE' | 'MODULE';
 export const VENUE_RESULT = 'VENUE';
 export const MODULE_RESULT = 'MODULE';
 export const SEARCH_RESULT = 'SEARCH';
@@ -25,7 +25,7 @@ export type SearchResult = {
 export type SearchItem =
   | { readonly type: 'VENUE'; readonly venue: Venue }
   | { readonly type: 'MODULE'; readonly module: ModuleCondensed }
-  | { readonly type: 'SEARCH'; readonly result: 'MODULE' | 'VENUE'; readonly term: string };
+  | { readonly type: 'SEARCH'; readonly result: SearchResultType; readonly term: string };
 
 /* browse/ModuleFinderContainer */
 export type RefinementItem = { key: string; doc_count?: number; missing?: boolean };

website/src/views/layout/GlobalSearch.tsx

@@ -9,7 +9,7 @@ import { ModuleCondensed } from 'types/modules';
 import { Venue } from 'types/venues';
 import {
   MODULE_RESULT,
-  ResultType,
+  SearchResultType,
   SEARCH_RESULT,
   SearchItem,
   SearchResult,
@@ -25,7 +25,7 @@ type Props = {
 
   onSelectVenue: (venue: Venue) => void;
   onSelectModule: (moduleCondensed: ModuleCondensed) => void;
-  onSearch: (resultType: ResultType, str: string) => void;
+  onSearch: (type: SearchResultType, query: string) => void;
 };
 
 type State = {
@@ -91,7 +91,7 @@ class GlobalSearch extends Component<Props, State> {
           break;
 
         case SEARCH_RESULT:
-          onSearch(item.type, item.term);
+          onSearch(item.result, item.term);
           break;
       }
     }

website/src/views/layout/GlobalSearchContainer.tsx

@@ -10,7 +10,7 @@ import useMediaQuery from 'views/hooks/useMediaQuery';
 import GlobalSearch from 'views/layout/GlobalSearch';
 import { modulePage, venuePage } from 'views/routes/paths';
 
-import { ResultType, SearchResult, VENUE_RESULT } from 'types/views';
+import { SearchResultType, SearchResult, VENUE_RESULT } from 'types/views';
 import { fetchVenueList } from 'actions/venueBank';
 import { createSearchPredicate, regexify, sortModules, tokenize } from 'utils/moduleSearch';
 import { breakpointUp } from 'utils/css';
@@ -42,7 +42,7 @@ const GlobalSearchContainer: FC = () => {
   );
 
   const onSearch = useCallback(
-    (type: ResultType, query: string) => {
+    (type: SearchResultType, query: string) => {
       // TODO: Move this into a proper function
       const path = type === VENUE_RESULT ? '/venues' : '/courses';
       history.push(`${path}?q=${encodeURIComponent(query)}`);