tsconfig: enable some stricter type checking options (#3500)

Author: zwliew

website/src/actions/export.ts

@@ -23,7 +23,7 @@ function downloadUrl(blob: Blob, filename: string) {
 export const SUPPORTS_DOWNLOAD = 'download' in document.createElement('a');
 
 export function downloadAsIcal(semester: Semester) {
-  return (dispatch: Dispatch, getState: GetState) => {
+  return (_dispatch: Dispatch, getState: GetState) => {
     Promise.all([
       retryImport(() => import(/* webpackChunkName: "export" */ 'ical-generator')),
       retryImport(() => import(/* webpackChunkName: "export" */ 'utils/ical')),

website/src/bootstrapping/matomo.ts

@@ -68,7 +68,7 @@ export function setCustomDimensions(dimensions: { [id: number]: string }) {
 }
 
 export function trackPageView(history: History) {
-  history.listen((location, action) => {
+  history.listen((_location, action) => {
     if (action === 'PUSH') {
       // Wait a bit for the page title to update
       setTimeout(() => {

website/src/entry/export/TimetableOnly.tsx

@@ -21,13 +21,13 @@ type State = {
 };
 
 export default class TimetableOnly extends Component<Props, State> {
-  state = {
+  override state = {
     semester: 1,
     timetable: {},
     colors: {},
   };
 
-  render() {
+  override render() {
     const { store } = this.props;
     const theme = store.getState().theme.id;
 

website/src/reducers/index.test.ts

@@ -41,7 +41,7 @@ const exportData: ExportData = {
 jest.mock(
   'storage/persistReducer',
   <T>() =>
-    (key: string, reducer: T) =>
+    (_key: string, reducer: T) =>
       reducer,
 );
 

website/src/reducers/timetables.ts

@@ -43,7 +43,7 @@ export const persistConfig = {
   stateReconciler: (
     inbound: TimetablesState,
     original: TimetablesState,
-    reduced: TimetablesState,
+    _reduced: TimetablesState,
     { debug }: PersistConfig<TimetablesState>,
   ): TimetablesState => {
     if (inbound.academicYear === original.academicYear) {

website/src/serverless/handler.ts

@@ -49,7 +49,7 @@ export const createRouteHandler =
 
 export const defaultFallback =
   (methodHandlers: MethodHandlers) =>
-  async (req: Request, res: Response): Promise<void> => {
+  async (_req: Request, res: Response): Promise<void> => {
     const allowedMethods = Object.entries(methodHandlers).reduce((acc, [method, handler]) => {
       if (handler !== undefined) {
         if (acc === '') return method;
@@ -66,7 +66,7 @@ export const defaultFallback =
 export const defaultRescue =
   (enableLogging: boolean) =>
   (err: Error) =>
-  async (req: Request, res: Response): Promise<void> => {
+  async (_req: Request, res: Response): Promise<void> => {
     if (enableLogging) {
       // eslint-disable-next-line no-console
       console.error(err);

website/src/utils/error.ts

@@ -3,7 +3,7 @@ import { each, size } from 'lodash';
 
 export function captureException(error: Error, extra: { [key: string]: unknown } = {}) {
   Sentry.withScope((scope) => {
-    each(extra, (data, key) => {
+    each(extra, (_data, key) => {
       scope.setExtra(key, extra[key]);
     });
 

website/src/utils/ical.ts

@@ -83,7 +83,7 @@ function calculateStartEnd(date: Date, startTime: StartTime, endTime: EndTime) {
 
 export function calculateNumericWeek(
   lesson: RawLesson,
-  semester: Semester,
+  _semester: Semester,
   weeks: NumericWeeks,
   firstDayOfSchool: Date,
 ): EventOption {
@@ -108,7 +108,7 @@ export function calculateNumericWeek(
 
 export function calculateWeekRange(
   lesson: RawLesson,
-  semester: Semester,
+  _semester: Semester,
   weekRange: WeekRange,
 ): EventOption {
   const rangeStart = parseDate(weekRange.start);

website/src/views/components/Online.tsx

@@ -14,13 +14,13 @@ export class OnlineComponent extends React.Component<Props> {
     isLive: true,
   };
 
-  shouldComponentUpdate(nextProps: Props) {
+  override shouldComponentUpdate(nextProps: Props) {
     // Do not rerender if the component is not live and the only thing
     // that has changed is the online status
     return nextProps.isLive || nextProps.children !== this.props.children;
   }
 
-  render() {
+  override render() {
     const { children, isOnline } = this.props;
 
     if (typeof children === 'function') {

website/src/views/components/SearchBox.tsx

@@ -92,7 +92,7 @@ export default class SearchBox extends React.PureComponent<Props, State> {
     );
   }
 
-  render() {
+  override render() {
     const { value, placeholder, isLoading } = this.props;
     return (
       <div