fix(optimiser): Prevent invalid time range #4113
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@sevensxyt is attempting to deploy a commit to the modsbot's projects Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4113 +/- ##
==========================================
- Coverage 54.52% 52.91% -1.62%
==========================================
Files 274 289 +15
Lines 6076 6696 +620
Branches 1455 1633 +178
==========================================
+ Hits 3313 3543 +230
- Misses 2763 3153 +390 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sevensxyt
changed the title
|
Hi @sevensxyt, thanks for the PR. I'm currently working on a refactor of the optimiser component in #4094, and it also modifies the time select. I'll update you again when those changes are ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
On the optimiser page, time options for the dropdown lists are not filtered. This allows invalid time ranges to be selected, where the start time is after the end time, as shown below:
Start time
18:00is after end time14:00Implementation
Other Information
I've also added tests for the utility functions added