Skip to content

Commit f556ffd

Browse files
committed
Merge branch 'develop'
2 parents d60d302 + 7a00aa1 commit f556ffd

File tree

11 files changed

+177
-194
lines changed

11 files changed

+177
-194
lines changed

.github/workflows/ci.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
name: Run CI
22
on:
3-
push:
4-
branches-ignore:
5-
- develop
6-
- release/**
7-
paths-ignore:
8-
- '**/*.md'
3+
# push:
4+
# branches-ignore:
5+
# - develop
6+
# - release/**
7+
# paths-ignore:
8+
# - '**/*.md'
99
pull_request:
1010

1111
jobs:
@@ -18,7 +18,7 @@ jobs:
1818
- name: Set up node
1919
uses: actions/setup-node@v2
2020
with:
21-
node-version: 14
21+
node-version: 16
2222
- name: Setup Docker
2323
run: |
2424
docker pull s1hofmann/nut-ci:latest
@@ -57,7 +57,7 @@ jobs:
5757
strategy:
5858
matrix:
5959
os: [ windows-latest, macos-latest ]
60-
node: [ 14 ]
60+
node: [ 16 ]
6161
runs-on: ${{matrix.os}}
6262
steps:
6363
- name: Set up Git repository

.github/workflows/orga.yaml

Lines changed: 0 additions & 22 deletions
This file was deleted.

.github/workflows/snapshot_release.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
strategy:
1515
matrix:
1616
os: [ ubuntu-latest, windows-latest, macos-latest ]
17-
node: [ 14 ]
17+
node: [ 16 ]
1818
runs-on: ${{matrix.os}}
1919
steps:
2020
- name: Set up Git repository
@@ -59,7 +59,7 @@ jobs:
5959
- name: Set up node
6060
uses: actions/setup-node@v2
6161
with:
62-
node-version: 14
62+
node-version: 16
6363
registry-url: 'https://registry.npmjs.org'
6464
- name: Install
6565
run: npm ci

.github/workflows/tagged_release.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
strategy:
1010
matrix:
1111
os: [ ubuntu-latest, windows-latest, macos-latest ]
12-
node: [ 14 ]
12+
node: [ 16 ]
1313
runs-on: ${{matrix.os}}
1414
steps:
1515
- name: Set up Git repository
@@ -51,7 +51,7 @@ jobs:
5151
- name: Set up node
5252
uses: actions/setup-node@v2
5353
with:
54-
node-version: 14
54+
node-version: 16
5555
registry-url: 'https://registry.npmjs.org'
5656
- name: Install
5757
run: npm ci

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,13 @@
22

33
All notable changes to this project will be documented in this file.
44

5+
## 2.2.0
6+
- Maintenance: Limit CI runs to PRs, not every push
7+
- Maintenance: Upgrade node version to 16 for all CI runs
8+
- Bugfix: Fix grave accent [(PR #414)](https://github.com/nut-tree/nut.js/pull/414)
9+
- Enhancement: Refine error messages on fetchFromUrl [(#415)](https://github.com/nut-tree/nut.js/issues/415)
10+
- Enhancement: Ship Windows runtime dependencies [(#365)](https://github.com/nut-tree/nut.js/issues/365)
11+
512
## 2.1.1
613
- Bugfix: Modifier keys are not properly released on macOS [(#264)](https://github.com/nut-tree/nut.js/issues/264)
714
- Bugfix: Fix mouse clicks with modifiers on macOS [(#273)](https://github.com/nut-tree/nut.js/issues/273)

README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,7 @@ This section lists runtime requirements for `nut.js` on the respective target pl
150150

151151
#### Windows
152152

153-
In order to install `nut.js` on Windows, please make sure to have the [Microsoft Visual C++ Redistributable](https://support.microsoft.com/en-us/help/2977003/the-latest-supported-visual-c-downloads) installed.
154-
155-
In case you're running Windows 10 N, please make sure to have the [Media Feature Pack](https://support.microsoft.com/en-us/topic/media-feature-pack-for-windows-10-n-may-2020-ebbdf559-b84c-0fc2-bd51-e23c9f6a4439) installed as well.
153+
In case you're running Windows 10 N and want to use [ImageFinder plugins](https://nutjs.dev/plugins/imagefinder), please make sure to have the [Media Feature Pack](https://support.microsoft.com/en-us/topic/media-feature-pack-for-windows-10-n-may-2020-ebbdf559-b84c-0fc2-bd51-e23c9f6a4439) installed.
156154

157155
#### macOS
158156

lib/imageResources.function.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ describe('fetchFromUrl', () => {
3737
const SUT = () => fetchFromUrl(malformedUrl);
3838

3939
// THEN
40-
await expect(SUT).rejects.toThrowError("Invalid URL");
40+
await expect(SUT).rejects.toThrowError("Failed to fetch image data. Reason: Invalid URL");
4141
});
4242

4343
it('should throw on non-image URLs', async () => {
@@ -48,7 +48,7 @@ describe('fetchFromUrl', () => {
4848
const SUT = () => fetchFromUrl(nonImageUrl);
4949

5050
// THEN
51-
await expect(SUT).rejects.toThrowError('Could not find MIME for Buffer');
51+
await expect(SUT).rejects.toThrowError("Failed to parse image data. Reason: Could not find MIME for Buffer");
5252
});
5353

5454
it('should return an RGB image from a valid URL', async () => {

lib/imageResources.function.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ export async function fetchFromUrl(url: string | URL): Promise<Image> {
2222
} else {
2323
try {
2424
imageUrl = new URL(url);
25-
} catch (e) {
26-
throw e;
25+
} catch (e: any) {
26+
throw new Error(`Failed to fetch image data. Reason: ${e.message}`);
2727
}
2828
}
2929
return Jimp.read(imageUrl.href)
@@ -38,6 +38,6 @@ export async function fetchFromUrl(url: string | URL): Promise<Image> {
3838
);
3939
})
4040
.catch(err => {
41-
throw err;
41+
throw new Error(`Failed to parse image data. Reason: ${err.message}`);
4242
});
4343
}

lib/provider/native/libnut-keyboard.class.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ export default class KeyboardAction implements KeyboardProviderInterface {
9292
[Key.RightShift, "space"],
9393
[Key.RightSuper, "command"],
9494

95-
[Key.Grave, "~"],
95+
[Key.Grave, "`"],
9696
[Key.Minus, "-"],
9797
[Key.Equal, "="],
9898
[Key.Backspace, "backspace"],

0 commit comments

Comments
 (0)