fixed segfault in HOG bindings due to invoking HOG copy constructor

Author: justadudewhohacks

cc/modules/objdetect/HOGDescriptor.cc

@@ -85,7 +85,7 @@ NAN_METHOD(HOGDescriptor::New) {
   }
 
   HOGDescriptor* self = new HOGDescriptor();
-  self->hog = cv::HOGDescriptor(
+  self->hog = std::make_shared<cv::HOGDescriptor>(
     winSize,
     blockSize,
     blockStride,
@@ -115,7 +115,7 @@ NAN_METHOD(HOGDescriptor::GetDefaultPeopleDetector) {
 }
 
 NAN_METHOD(HOGDescriptor::CheckDetectorSize) {
-  FF_RETURN(Nan::New(HOGDescriptor::Converter::unwrap(info.This()).checkDetectorSize()));
+  FF_RETURN(Nan::New(HOGDescriptor::Converter::unwrap(info.This())->checkDetectorSize()));
 }
 
 NAN_METHOD(HOGDescriptor::SetSVMDetector) {
@@ -124,22 +124,23 @@ NAN_METHOD(HOGDescriptor::SetSVMDetector) {
   if (!FF_HAS_ARG(0) || FloatArrayConverter::unwrap(&detector, info[0])) {
     FF_THROW("expected detector to be an Array of type Number");
   }
-  HOGDescriptor::Converter::unwrapPtr(info.This())->setSVMDetector(detector);
+  HOGDescriptor::Converter::unwrap(info.This())->setSVMDetector(detector);
 }
 
 NAN_METHOD(HOGDescriptor::Save) {
   FF_METHOD_CONTEXT("HOGDescriptor::Save");
   FF_ARG_STRING(0, std::string path);
-  FF_UNWRAP(info.This(), HOGDescriptor)->hog.save(path);
+  FF_UNWRAP(info.This(), HOGDescriptor)->hog->save(path);
 }
 
 NAN_METHOD(HOGDescriptor::Load) {
   FF_METHOD_CONTEXT("HOGDescriptor::Load");
   FF_ARG_STRING(0, std::string path);
-  FF_UNWRAP(info.This(), HOGDescriptor)->hog.load(path);
+  FF_UNWRAP(info.This(), HOGDescriptor)->hog->load(path);
 }
 
 NAN_METHOD(HOGDescriptor::Compute) {
+      std::cout << "Compute" << std::endl;
   FF::SyncBinding(
     std::make_shared<HOGDescriptorBindings::ComputeWorker>(HOGDescriptor::Converter::unwrap(info.This())),
     "HOGDescriptor::Compute",

cc/modules/objdetect/HOGDescriptor.h

@@ -13,31 +13,31 @@
 
 class HOGDescriptor : public Nan::ObjectWrap {
 public:
-	cv::HOGDescriptor hog;
+	std::shared_ptr<cv::HOGDescriptor> hog;
 
 	static Nan::Persistent<v8::FunctionTemplate> constructor;
 
-	cv::HOGDescriptor* getNativeObjectPtr() { return &hog; }
-	cv::HOGDescriptor getNativeObject() { return hog; }
+	cv::HOGDescriptor* getNativeObjectPtr() { return hog.get(); }
+	std::shared_ptr<cv::HOGDescriptor> getNativeObject() { return hog; }
 
-	typedef InstanceConverter<HOGDescriptor, cv::HOGDescriptor> Converter;
+	typedef InstanceConverter<HOGDescriptor, 	std::shared_ptr<cv::HOGDescriptor>> Converter;
 
 	static const char* getClassName() {
 		return "HOGDescriptor";
 	}
 
-	static FF_GETTER_JSOBJ(HOGDescriptor, winSize, hog.winSize, FF_UNWRAP_SIZE_AND_GET, Size::constructor);
-	static FF_GETTER_JSOBJ(HOGDescriptor, blockSize, hog.blockSize, FF_UNWRAP_SIZE_AND_GET, Size::constructor);
-	static FF_GETTER_JSOBJ(HOGDescriptor, blockStride, hog.blockStride, FF_UNWRAP_SIZE_AND_GET, Size::constructor);
-	static FF_GETTER_JSOBJ(HOGDescriptor, cellSize, hog.cellSize, FF_UNWRAP_SIZE_AND_GET, Size::constructor);
-	static FF_GETTER(HOGDescriptor, nbins, hog.nbins);
-	static FF_GETTER(HOGDescriptor, derivAperture, hog.derivAperture);
-	static FF_GETTER(HOGDescriptor, histogramNormType, hog.histogramNormType);
-	static FF_GETTER(HOGDescriptor, nlevels, hog.nlevels);
-	static FF_GETTER(HOGDescriptor, winSigma, hog.winSigma);
-	static FF_GETTER(HOGDescriptor, L2HysThreshold, hog.L2HysThreshold);
-	static FF_GETTER(HOGDescriptor, gammaCorrection, hog.gammaCorrection);
-	static FF_GETTER(HOGDescriptor, signedGradient, hog.signedGradient);
+	static FF_GETTER_JSOBJ(HOGDescriptor, winSize, hog->winSize, FF_UNWRAP_SIZE_AND_GET, Size::constructor);
+	static FF_GETTER_JSOBJ(HOGDescriptor, blockSize, hog->blockSize, FF_UNWRAP_SIZE_AND_GET, Size::constructor);
+	static FF_GETTER_JSOBJ(HOGDescriptor, blockStride, hog->blockStride, FF_UNWRAP_SIZE_AND_GET, Size::constructor);
+	static FF_GETTER_JSOBJ(HOGDescriptor, cellSize, hog->cellSize, FF_UNWRAP_SIZE_AND_GET, Size::constructor);
+	static FF_GETTER(HOGDescriptor, nbins, hog->nbins);
+	static FF_GETTER(HOGDescriptor, derivAperture, hog->derivAperture);
+	static FF_GETTER(HOGDescriptor, histogramNormType, hog->histogramNormType);
+	static FF_GETTER(HOGDescriptor, nlevels, hog->nlevels);
+	static FF_GETTER(HOGDescriptor, winSigma, hog->winSigma);
+	static FF_GETTER(HOGDescriptor, L2HysThreshold, hog->L2HysThreshold);
+	static FF_GETTER(HOGDescriptor, gammaCorrection, hog->gammaCorrection);
+	static FF_GETTER(HOGDescriptor, signedGradient, hog->signedGradient);
 
 	static NAN_MODULE_INIT(Init);