Skip to content

Commit dba1989

Browse files
mathetakenutanix-Hrushikesh
authored andcommitted
ci: skip test_e2e_aigw on doc chaneg & fix docker job requirement (envoyproxy#1296)
**Description** Previously, test_e2e_aigw was not skipped unlike others when there's only doc changes in the PR. Also, it was not required in the docker build&push on the main branch, so this commit fixes these two issues. Signed-off-by: Takeshi Yoneda <[email protected]> Signed-off-by: Hrushikesh Patil <[email protected]>
1 parent 57221d1 commit dba1989

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

.github/workflows/build_and_test.yaml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -328,6 +328,7 @@ jobs:
328328
test_e2e_aigw:
329329
needs: changes
330330
name: E2E Test for aigw CLI
331+
if: ${{ needs.changes.outputs.code == 'true' }}
331332
runs-on: ubuntu-latest
332333
steps:
333334
- uses: actions/checkout@v4
@@ -370,15 +371,7 @@ jobs:
370371
# Docker builds are verified in test_e2e job, so we only need to push the images when the event is a push event.
371372
if: github.event_name == 'push'
372373
name: Push Docker Images
373-
needs:
374-
[
375-
unittest,
376-
test_crdcel,
377-
test_controller,
378-
test_extproc,
379-
test_e2e,
380-
test_e2e_inference_extension,
381-
]
374+
needs: [ci-required]
382375
uses: ./.github/workflows/docker_build_job.yaml
383376
secrets: inherit
384377

0 commit comments

Comments
 (0)