test: Unit test for validating multiple NICs order and duplicate IPs

Author: legacyrj

pkg/provider/manager_unit_test.go

@@ -1,9 +1,16 @@
 package provider
 
 import (
+	"context"
+	"net/netip"
+	"slices"
 	"testing"
 
+	vmmCommonModels "github.com/nutanix/ntnx-api-golang-clients/vmm-go-client/v4/models/common/v1/config"
+	vmmModels "github.com/nutanix/ntnx-api-golang-clients/vmm-go-client/v4/models/vmm/v4/ahv/config"
+	"go4.org/netipx"
 	v1 "k8s.io/api/core/v1"
+	"k8s.io/utils/ptr"
 )
 
 func TestIsNodeAddressesSet(t *testing.T) {
@@ -81,3 +88,127 @@ func TestIsNodeAddressesSet(t *testing.T) {
 		})
 	}
 }
+
+func TestGetNodeAddresses(t *testing.T) {
+	ctx := context.Background()
+
+	tests := []struct {
+		name    string
+		vm      *vmmModels.Vm
+		wantErr bool
+		wantIPs []string
+		wantLen int
+	}{
+		{
+			name: "VM with no NICs returns error",
+			vm: &vmmModels.Vm{
+				ExtId: ptr.To("uuid"),
+				Name:  ptr.To("vm1"),
+				Nics:  nil,
+			},
+			wantErr: true,
+		},
+		{
+			name:    "VM with one NIC returns internal IP and hostname",
+			vm:      vmWithOneNic(t, "my-vm1", "uuid-1", "10.0.0.1"),
+			wantErr: false,
+			wantIPs: []string{"10.0.0.1"},
+			wantLen: 2, // 1 NodeInternalIP + 1 NodeHostName
+		},
+		{
+			name:    "multiple NICs: internal IPs appear in NIC order",
+			vm:      vmWithNics(t, "my-vm", "uuid-2", []string{"10.0.0.1", "10.0.0.2", "10.0.0.3"}),
+			wantErr: false,
+			wantIPs: []string{"10.0.0.1", "10.0.0.2", "10.0.0.3"},
+			wantLen: 4, // 3 NodeInternalIP + 1 NodeHostName
+		},
+		{
+			name:    "multiple NICs with same IP: deduplicated to one internal IP",
+			vm:      vmWithNics(t, "my-vm", "uuid-3", []string{"10.0.0.1", "10.0.0.1"}),
+			wantErr: false,
+			wantIPs: []string{"10.0.0.1"},
+			wantLen: 2,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			m := &nutanixManager{
+				ignoredNodeIPs: ignoredIPSet("10.0.0.99"),
+			}
+			got, err := m.getNodeAddresses(ctx, tt.vm)
+			if tt.wantErr {
+				if err == nil {
+					t.Errorf("getNodeAddresses() expected error, got nil")
+				}
+				return
+			}
+			if err != nil {
+				t.Errorf("getNodeAddresses() err = %v", err)
+				return
+			}
+			if tt.wantLen != 0 && len(got) != tt.wantLen {
+				t.Errorf("getNodeAddresses() len = %d, want %d", len(got), tt.wantLen)
+			}
+			if len(tt.wantIPs) > 0 {
+				ips := extractInternalIPs(got)
+				if !slices.Equal(ips, tt.wantIPs) {
+					t.Errorf("getNodeAddresses() internal IPs = %v, want %v", ips, tt.wantIPs)
+				}
+			}
+		})
+	}
+}
+
+func extractInternalIPs(addrs []v1.NodeAddress) []string {
+	var out []string
+	for _, a := range addrs {
+		if a.Type == v1.NodeInternalIP {
+			out = append(out, a.Address)
+		}
+	}
+	return out
+}
+
+func ignoredIPSet(ips ...string) *netipx.IPSet {
+	b := netipx.IPSetBuilder{}
+	for _, s := range ips {
+		b.Add(netip.MustParseAddr(s))
+	}
+	s, _ := b.IPSet()
+	return s
+}
+
+func vmWithOneNic(t *testing.T, name, uuid, ip string) *vmmModels.Vm {
+	t.Helper()
+	return vmWithNics(t, name, uuid, []string{ip})
+}
+
+// nicWithIP returns a NIC with the given IPv4 address.
+func nicWithIP(t *testing.T, ip string) vmmModels.Nic {
+	t.Helper()
+	nic := vmmModels.NewNic()
+	netInfo := vmmModels.NewVirtualEthernetNicNetworkInfo()
+	netInfo.Ipv4Config = vmmModels.NewIpv4Config()
+	netInfo.Ipv4Config.IpAddress = &vmmCommonModels.IPv4Address{Value: ptr.To(ip)}
+	netInfo.Ipv4Info = vmmModels.NewIpv4Info()
+	netInfo.Ipv4Info.LearnedIpAddresses = []vmmCommonModels.IPv4Address{{Value: ptr.To(ip)}}
+	if err := nic.SetNicNetworkInfo(*netInfo); err != nil {
+		t.Fatalf("SetNicNetworkInfo: %v", err)
+	}
+	return *nic
+}
+
+// vmWithNics returns a VM with one NIC per IP; order of IPs matches order of NICs.
+func vmWithNics(t *testing.T, name, uuid string, ips []string) *vmmModels.Vm {
+	t.Helper()
+	nics := make([]vmmModels.Nic, 0, len(ips))
+	for _, ip := range ips {
+		nics = append(nics, nicWithIP(t, ip))
+	}
+	return &vmmModels.Vm{
+		ExtId: ptr.To(uuid),
+		Name:  ptr.To(name),
+		Nics:  nics,
+	}
+}