|
| 1 | +/* |
| 2 | +Copyright 2025 Nutanix |
| 3 | +
|
| 4 | +Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | +you may not use this file except in compliance with the License. |
| 6 | +You may obtain a copy of the License at |
| 7 | +
|
| 8 | + http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | +
|
| 10 | +Unless required by applicable law or agreed to in writing, software |
| 11 | +distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | +See the License for the specific language governing permissions and |
| 14 | +limitations under the License. |
| 15 | +*/ |
| 16 | + |
| 17 | +package v1beta1 |
| 18 | + |
| 19 | +import ( |
| 20 | + "encoding/json" |
| 21 | + "testing" |
| 22 | + |
| 23 | + "github.com/stretchr/testify/assert" |
| 24 | + "github.com/stretchr/testify/require" |
| 25 | + "k8s.io/apimachinery/pkg/api/resource" |
| 26 | + "k8s.io/utils/ptr" |
| 27 | +) |
| 28 | + |
| 29 | +func TestNutanixMachineSpec_JSONMarshalling(t *testing.T) { |
| 30 | + tests := []struct { |
| 31 | + name string |
| 32 | + spec NutanixMachineSpec |
| 33 | + expectedJSON string |
| 34 | + shouldContain []string |
| 35 | + shouldNotContain []string |
| 36 | + }{ |
| 37 | + { |
| 38 | + name: "marshalling with zero-value cluster should omit cluster field", |
| 39 | + spec: NutanixMachineSpec{ |
| 40 | + VCPUsPerSocket: 2, |
| 41 | + VCPUSockets: 1, |
| 42 | + MemorySize: resource.MustParse("4Gi"), |
| 43 | + SystemDiskSize: resource.MustParse("20Gi"), |
| 44 | + Subnets: []NutanixResourceIdentifier{ |
| 45 | + { |
| 46 | + Type: NutanixIdentifierUUID, |
| 47 | + UUID: ptr.To("subnet-uuid"), |
| 48 | + }, |
| 49 | + }, |
| 50 | + // Cluster field is intentionally left as zero value |
| 51 | + }, |
| 52 | + shouldNotContain: []string{`"cluster"`}, |
| 53 | + shouldContain: []string{`"vcpusPerSocket"`, `"vcpuSockets"`, `"memorySize"`, `"systemDiskSize"`, `"subnet"`}, |
| 54 | + }, |
| 55 | + { |
| 56 | + name: "marshalling with populated cluster should include cluster field", |
| 57 | + spec: NutanixMachineSpec{ |
| 58 | + VCPUsPerSocket: 2, |
| 59 | + VCPUSockets: 1, |
| 60 | + MemorySize: resource.MustParse("4Gi"), |
| 61 | + SystemDiskSize: resource.MustParse("20Gi"), |
| 62 | + Cluster: NutanixResourceIdentifier{ |
| 63 | + Type: NutanixIdentifierUUID, |
| 64 | + UUID: ptr.To("cluster-uuid"), |
| 65 | + }, |
| 66 | + Subnets: []NutanixResourceIdentifier{ |
| 67 | + { |
| 68 | + Type: NutanixIdentifierUUID, |
| 69 | + UUID: ptr.To("subnet-uuid"), |
| 70 | + }, |
| 71 | + }, |
| 72 | + }, |
| 73 | + shouldContain: []string{`"cluster"`, `"vcpusPerSocket"`, `"vcpuSockets"`, `"memorySize"`, `"systemDiskSize"`, `"subnet"`}, |
| 74 | + }, |
| 75 | + { |
| 76 | + name: "marshalling with cluster by name should include cluster field", |
| 77 | + spec: NutanixMachineSpec{ |
| 78 | + VCPUsPerSocket: 2, |
| 79 | + VCPUSockets: 1, |
| 80 | + MemorySize: resource.MustParse("4Gi"), |
| 81 | + SystemDiskSize: resource.MustParse("20Gi"), |
| 82 | + Cluster: NutanixResourceIdentifier{ |
| 83 | + Type: NutanixIdentifierName, |
| 84 | + Name: ptr.To("cluster-name"), |
| 85 | + }, |
| 86 | + Subnets: []NutanixResourceIdentifier{ |
| 87 | + { |
| 88 | + Type: NutanixIdentifierName, |
| 89 | + Name: ptr.To("subnet-name"), |
| 90 | + }, |
| 91 | + }, |
| 92 | + }, |
| 93 | + shouldContain: []string{`"cluster"`, `"cluster-name"`, `"vcpusPerSocket"`, `"vcpuSockets"`, `"memorySize"`, `"systemDiskSize"`, `"subnet"`}, |
| 94 | + }, |
| 95 | + { |
| 96 | + name: "marshalling with explicitly empty cluster struct should omit cluster field", |
| 97 | + spec: NutanixMachineSpec{ |
| 98 | + VCPUsPerSocket: 2, |
| 99 | + VCPUSockets: 1, |
| 100 | + MemorySize: resource.MustParse("4Gi"), |
| 101 | + SystemDiskSize: resource.MustParse("20Gi"), |
| 102 | + Cluster: NutanixResourceIdentifier{ |
| 103 | + // Explicitly created empty struct with zero values |
| 104 | + Type: "", |
| 105 | + UUID: nil, |
| 106 | + Name: nil, |
| 107 | + }, |
| 108 | + Subnets: []NutanixResourceIdentifier{ |
| 109 | + { |
| 110 | + Type: NutanixIdentifierUUID, |
| 111 | + UUID: ptr.To("subnet-uuid"), |
| 112 | + }, |
| 113 | + }, |
| 114 | + }, |
| 115 | + shouldNotContain: []string{`"cluster"`}, |
| 116 | + shouldContain: []string{`"vcpusPerSocket"`, `"vcpuSockets"`, `"memorySize"`, `"systemDiskSize"`, `"subnet"`}, |
| 117 | + }, |
| 118 | + } |
| 119 | + |
| 120 | + for _, tt := range tests { |
| 121 | + t.Run(tt.name, func(t *testing.T) { |
| 122 | + jsonBytes, err := json.Marshal(tt.spec) |
| 123 | + require.NoError(t, err, "Failed to marshal NutanixMachineSpec") |
| 124 | + |
| 125 | + jsonString := string(jsonBytes) |
| 126 | + |
| 127 | + // Check for strings that should be present |
| 128 | + for _, shouldContain := range tt.shouldContain { |
| 129 | + assert.Contains(t, jsonString, shouldContain, "Expected JSON to contain %q", shouldContain) |
| 130 | + } |
| 131 | + |
| 132 | + // Check for strings that should not be present |
| 133 | + for _, shouldNotContain := range tt.shouldNotContain { |
| 134 | + assert.NotContains(t, jsonString, shouldNotContain, "Expected JSON to NOT contain %q", shouldNotContain) |
| 135 | + } |
| 136 | + |
| 137 | + // Test that we can unmarshal back to the same structure |
| 138 | + var unmarshaledSpec NutanixMachineSpec |
| 139 | + require.NoError(t, json.Unmarshal(jsonBytes, &unmarshaledSpec), "Failed to unmarshal JSON back to NutanixMachineSpec") |
| 140 | + |
| 141 | + // Verify critical fields are preserved |
| 142 | + assert.Equal(t, tt.spec.VCPUsPerSocket, unmarshaledSpec.VCPUsPerSocket, "VCPUsPerSocket mismatch") |
| 143 | + assert.Equal(t, tt.spec.VCPUSockets, unmarshaledSpec.VCPUSockets, "VCPUSockets mismatch") |
| 144 | + assert.True(t, unmarshaledSpec.MemorySize.Equal(tt.spec.MemorySize), "MemorySize mismatch: expected %v, got %v", tt.spec.MemorySize, unmarshaledSpec.MemorySize) |
| 145 | + assert.True(t, unmarshaledSpec.SystemDiskSize.Equal(tt.spec.SystemDiskSize), "SystemDiskSize mismatch: expected %v, got %v", tt.spec.SystemDiskSize, unmarshaledSpec.SystemDiskSize) |
| 146 | + |
| 147 | + // Verify cluster field behavior |
| 148 | + if tt.spec.Cluster.Type != "" { |
| 149 | + // If original had a cluster, unmarshaled should too |
| 150 | + assert.Equal(t, tt.spec.Cluster.Type, unmarshaledSpec.Cluster.Type, "Cluster.Type mismatch") |
| 151 | + if tt.spec.Cluster.UUID != nil { |
| 152 | + require.NotNil(t, unmarshaledSpec.Cluster.UUID, "Expected Cluster.UUID to not be nil") |
| 153 | + assert.Equal(t, *tt.spec.Cluster.UUID, *unmarshaledSpec.Cluster.UUID, "Cluster.UUID mismatch") |
| 154 | + } |
| 155 | + if tt.spec.Cluster.Name != nil { |
| 156 | + require.NotNil(t, unmarshaledSpec.Cluster.Name, "Expected Cluster.Name to not be nil") |
| 157 | + assert.Equal(t, *tt.spec.Cluster.Name, *unmarshaledSpec.Cluster.Name, "Cluster.Name mismatch") |
| 158 | + } |
| 159 | + } else { |
| 160 | + // If original had zero cluster, unmarshaled should be zero too |
| 161 | + assert.Empty(t, unmarshaledSpec.Cluster.Type, "Expected unmarshaled cluster type to be empty") |
| 162 | + assert.Nil(t, unmarshaledSpec.Cluster.UUID, "Expected unmarshaled cluster UUID to be nil") |
| 163 | + assert.Nil(t, unmarshaledSpec.Cluster.Name, "Expected unmarshaled cluster Name to be nil") |
| 164 | + } |
| 165 | + }) |
| 166 | + } |
| 167 | +} |
| 168 | + |
| 169 | +func TestNutanixMachineSpec_JSONUnmarshalling(t *testing.T) { |
| 170 | + tests := []struct { |
| 171 | + name string |
| 172 | + jsonInput string |
| 173 | + expectError bool |
| 174 | + expectedSpec NutanixMachineSpec |
| 175 | + }{ |
| 176 | + { |
| 177 | + name: "unmarshalling JSON without cluster field should result in zero-value cluster", |
| 178 | + jsonInput: `{ |
| 179 | + "vcpusPerSocket": 2, |
| 180 | + "vcpuSockets": 1, |
| 181 | + "memorySize": "4Gi", |
| 182 | + "systemDiskSize": "20Gi", |
| 183 | + "subnet": [{"type": "uuid", "uuid": "subnet-uuid"}] |
| 184 | + }`, |
| 185 | + expectError: false, |
| 186 | + expectedSpec: NutanixMachineSpec{ |
| 187 | + VCPUsPerSocket: 2, |
| 188 | + VCPUSockets: 1, |
| 189 | + MemorySize: resource.MustParse("4Gi"), |
| 190 | + SystemDiskSize: resource.MustParse("20Gi"), |
| 191 | + Subnets: []NutanixResourceIdentifier{ |
| 192 | + { |
| 193 | + Type: NutanixIdentifierUUID, |
| 194 | + UUID: ptr.To("subnet-uuid"), |
| 195 | + }, |
| 196 | + }, |
| 197 | + // Cluster should be zero value |
| 198 | + }, |
| 199 | + }, |
| 200 | + { |
| 201 | + name: "unmarshalling JSON with cluster field should populate cluster", |
| 202 | + jsonInput: `{ |
| 203 | + "vcpusPerSocket": 2, |
| 204 | + "vcpuSockets": 1, |
| 205 | + "memorySize": "4Gi", |
| 206 | + "systemDiskSize": "20Gi", |
| 207 | + "cluster": {"type": "uuid", "uuid": "cluster-uuid"}, |
| 208 | + "subnet": [{"type": "uuid", "uuid": "subnet-uuid"}] |
| 209 | + }`, |
| 210 | + expectError: false, |
| 211 | + expectedSpec: NutanixMachineSpec{ |
| 212 | + VCPUsPerSocket: 2, |
| 213 | + VCPUSockets: 1, |
| 214 | + MemorySize: resource.MustParse("4Gi"), |
| 215 | + SystemDiskSize: resource.MustParse("20Gi"), |
| 216 | + Cluster: NutanixResourceIdentifier{ |
| 217 | + Type: NutanixIdentifierUUID, |
| 218 | + UUID: ptr.To("cluster-uuid"), |
| 219 | + }, |
| 220 | + Subnets: []NutanixResourceIdentifier{ |
| 221 | + { |
| 222 | + Type: NutanixIdentifierUUID, |
| 223 | + UUID: ptr.To("subnet-uuid"), |
| 224 | + }, |
| 225 | + }, |
| 226 | + }, |
| 227 | + }, |
| 228 | + } |
| 229 | + |
| 230 | + for _, tt := range tests { |
| 231 | + t.Run(tt.name, func(t *testing.T) { |
| 232 | + var spec NutanixMachineSpec |
| 233 | + err := json.Unmarshal([]byte(tt.jsonInput), &spec) |
| 234 | + |
| 235 | + if tt.expectError { |
| 236 | + assert.Error(t, err, "Expected an error but got none") |
| 237 | + return |
| 238 | + } |
| 239 | + |
| 240 | + require.NoError(t, err, "Expected no error but got: %v", err) |
| 241 | + |
| 242 | + // Verify the unmarshaled spec matches expectations |
| 243 | + assert.Equal(t, tt.expectedSpec.VCPUsPerSocket, spec.VCPUsPerSocket, "VCPUsPerSocket mismatch") |
| 244 | + assert.Equal(t, tt.expectedSpec.VCPUSockets, spec.VCPUSockets, "VCPUSockets mismatch") |
| 245 | + assert.True(t, spec.MemorySize.Equal(tt.expectedSpec.MemorySize), "MemorySize mismatch: expected %v, got %v", tt.expectedSpec.MemorySize, spec.MemorySize) |
| 246 | + assert.True(t, spec.SystemDiskSize.Equal(tt.expectedSpec.SystemDiskSize), "SystemDiskSize mismatch: expected %v, got %v", tt.expectedSpec.SystemDiskSize, spec.SystemDiskSize) |
| 247 | + |
| 248 | + // Verify cluster field |
| 249 | + assert.Equal(t, tt.expectedSpec.Cluster.Type, spec.Cluster.Type, "Cluster.Type mismatch") |
| 250 | + if tt.expectedSpec.Cluster.UUID != nil { |
| 251 | + require.NotNil(t, spec.Cluster.UUID, "Expected Cluster.UUID to not be nil") |
| 252 | + assert.Equal(t, *tt.expectedSpec.Cluster.UUID, *spec.Cluster.UUID, "Cluster.UUID mismatch") |
| 253 | + } else { |
| 254 | + assert.Nil(t, spec.Cluster.UUID, "Expected Cluster.UUID to be nil") |
| 255 | + } |
| 256 | + }) |
| 257 | + } |
| 258 | +} |
0 commit comments