Retriable errors must not populate fatal error message in status

[prajnutanix]

/kind bug

What steps did you take and what happened:

This is during normal capx cluster deployment flow. I saw nutanixcluster object's status contain a fatal error for a retriable error scenario:
" Get "https://10.45.92.5:9440/api/nutanix/v3/users/me": dial tcp 10.45.92.5:9440: i/o timeout" . This went away after few minutes, and cluster deployment was a success.

What did you expect to happen:
Errors which upon retry also cannot be fixed (like password incorrect or connecting with PC endpoint returns http 404 etc), must populate FatalError message in status. Other retriable errors must not populate this field.

Anything else you would like to add:

Miscellaneous information that will assist in solving the issue.

Environment:

• Cluster-api-provider-nutanix version: v1.2.1

• Kubernetes version: (use kubectl version):
  Client Version: v1.25.3
  Kustomize Version: v4.5.7
  Server Version: v1.25.3

• OS (e.g. from /etc/os-release): CentOS 7

[nutanix-cn-prow-bot]

@prajnutanix: The label(s) kind/bug cannot be applied, because the repository doesn't have them.

In response to this:

/kind bug

What steps did you take and what happened:

This is during normal capx cluster deployment flow. I saw nutanixcluster object's status contain a fatal error for a retriable error scenario:
" Get "https://10.45.92.5:9440/api/nutanix/v3/users/me": dial tcp 10.45.92.5:9440: i/o timeout" . This went away after few minutes, and cluster deployment was a success.

What did you expect to happen:
Errors which upon retry also cannot be fixed (like password incorrect or connecting with PC endpoint returns http 404 etc), must populate FatalError message in status. Other retriable errors must not populate this field.

Anything else you would like to add:

Miscellaneous information that will assist in solving the issue.

Environment:

• Cluster-api-provider-nutanix version: v1.2.1

• Kubernetes version: (use kubectl version):
  Client Version: v1.25.3
  Kustomize Version: v4.5.7
  Server Version: v1.25.3

• OS (e.g. from /etc/os-release): CentOS 7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tuxtof]

@prajnutanix normally fix in recent release
can you retest and confirm
thanks