fix: Registry preflight check URL parse error is not an internal error

- If the URL cannot be parsed, fails the check, but does not use an
  internal error.
- Removes redundant parsing, and removes related error handling.

Author: dlipovetsky

pkg/webhook/preflight/generic/registry.go

@@ -76,7 +76,7 @@ func (r *registryCheck) checkRegistry(
 	registryURLParsed, err := url.ParseRequestURI(registryURL)
 	if err != nil {
 		result.Allowed = false
-		result.Error = true
+		result.Error = false
 		result.Causes = append(result.Causes,
 			preflight.Cause{
 				Message: fmt.Sprintf("failed to parse registry url %s with error: %s", registryURL, err),
@@ -125,19 +125,15 @@ func (r *registryCheck) checkRegistry(
 		regclient.WithConfigHost(mirrorHost),
 		regclient.WithUserAgent("regclient/example"),
 	)
-	mirrorRef, err := ref.NewHost(registryURLParsed.Host)
-	if err != nil {
-		result.Allowed = false
-		result.Error = true
-		result.Causes = append(result.Causes,
-			preflight.Cause{
-				Message: fmt.Sprintf("failed to create a client to verify registry configuration %s", err.Error()),
-				Field:   r.field,
-			},
-		)
-		return result
-	}
-	_, err = rc.Ping(ctx, mirrorRef) // ping will return an error for anything that's not 200
+	_, err = rc.Ping(ctx,
+		ref.Ref{
+			// Because we ping the registry, we only need the "registry" part of the ref.
+			Registry: registryURLParsed.Host,
+			// The default scheme is "reg""
+			Scheme: "reg",
+		},
+	)
+	// Ping will return an error for anything that's not 200.
 	if err != nil {
 		result.Allowed = false
 		result.Causes = append(result.Causes,

pkg/webhook/preflight/generic/registry_test.go

@@ -199,6 +199,49 @@ func TestRegistryCheck(t *testing.T) {
 				Allowed: true,
 			},
 		},
+		{
+			name:  "image registry with invalid URL",
+			field: "cluster.spec.topology.variables[.name=clusterConfig].value.imageRegistries[0]",
+			imageRegistry: &carenv1.ImageRegistry{
+				URL: "invalid-url",
+				Credentials: &carenv1.RegistryCredentials{
+					SecretRef: &carenv1.LocalObjectReference{
+						Name: "test-secret",
+					},
+				},
+			},
+			kclient: &mockK8sClient{
+				getSecretFunc: func(ctx context.Context,
+					key types.NamespacedName,
+					obj ctrlclient.Object,
+					opts ...ctrlclient.GetOption,
+				) error {
+					secret := obj.(*corev1.Secret)
+					secret.Data = map[string][]byte{
+						"username": []byte("testuser"),
+						"password": []byte("testpass"),
+						"ca.crt":   []byte("test-ca-cert"),
+					}
+					return nil
+				},
+			},
+			mockRegClientPingerFactory: func(...regclient.Opt) regClientPinger {
+				return &mockRegClient{
+					pingFunc: func(ref.Ref) error { return nil },
+				}
+			},
+			want: preflight.CheckResult{
+				Allowed: false,
+				Error:   false,
+				Causes: []preflight.Cause{
+					{
+						Message: fmt.Sprintf("failed to parse registry url %s with error: "+
+							"parse \"invalid-url\": invalid URI for request", "invalid-url"),
+						Field: "cluster.spec.topology.variables[.name=clusterConfig].value.imageRegistries[0].url",
+					},
+				},
+			},
+		},
 	}
 
 	for _, tc := range testCases {