Skip to content

Commit 174b507

Browse files
committed
fix: correct copy and args
1 parent c0b1aa4 commit 174b507

File tree

3 files changed

+6
-14
lines changed

3 files changed

+6
-14
lines changed

.goreleaser.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,7 @@ dockers:
108108
- hack/addons/mindthegap-helm-registry/repos.yaml
109109
build_flag_templates:
110110
- "--platform=linux/amd64"
111-
- "--pull"
112-
- "--builder=caren"
111+
- '--build-arg=VERSION=v{{ trimprefix .Version "v" }}'
113112
- "--label=org.opencontainers.image.created={{.CommitDate}}"
114113
- "--label=org.opencontainers.image.title=caren-helm-reg"
115114
- "--label=org.opencontainers.image.revision={{.FullCommit}}"
@@ -124,8 +123,7 @@ dockers:
124123
- hack/addons/mindthegap-helm-registry/repos.yaml
125124
build_flag_templates:
126125
- "--platform=linux/arm64"
127-
- "--pull"
128-
- "--builder=caren"
126+
- '--build-arg=VERSION=v{{ trimprefix .Version "v" }}'
129127
- "--label=org.opencontainers.image.created={{.CommitDate}}"
130128
- "--label=org.opencontainers.image.title=caren-helm-reg"
131129
- "--label=org.opencontainers.image.revision={{.FullCommit}}"

hack/addons/mindthegap-helm-registry/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@ RUN --mount=source=./hack/addons/mindthegap-helm-registry/repos.yaml,target=/rep
55
["/ko-app/mindthegap", "create", "bundle", "--helm-charts-file=/repos.yaml", "--output-file=/tmp/helm-charts.tar"]
66

77
FROM --platform=${TARGETPLATFORM} alpine
8-
COPY --from=bundle_builder /tmp/helm-charts.tar /charts/
9-
RUN mv /charts/helm-charts.tar /charts/helm-charts-$(date +%s).tar
8+
ARG VERSION
9+
COPY --from=bundle_builder /tmp/helm-charts.tar /charts/helm-charts-${VERSION}.tar

make/goreleaser.mk

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,6 @@ ifndef GORELEASER_CURRENT_TAG
88
export GORELEASER_CURRENT_TAG=$(GIT_TAG)
99
endif
1010

11-
.PHONY: buildx
12-
buildx:
13-
buildx:
14-
docker buildx create --name=caren || true
15-
docker run --privileged --rm tonistiigi/binfmt --install all &>/dev/null || true
16-
1711
.PHONY: build-snapshot
1812
build-snapshot: ## Builds a snapshot with goreleaser
1913
build-snapshot: go-generate ; $(info $(M) building snapshot $*)
@@ -27,7 +21,7 @@ build-snapshot: go-generate ; $(info $(M) building snapshot $*)
2721

2822
.PHONY: release
2923
release: ## Builds a release with goreleaser
30-
release: buildx go-generate ; $(info $(M) building release $*)
24+
release: go-generate ; $(info $(M) building release $*)
3125
goreleaser --verbose=$(GORELEASER_VERBOSE) \
3226
release \
3327
--clean \
@@ -37,7 +31,7 @@ release: buildx go-generate ; $(info $(M) building release $*)
3731

3832
.PHONY: release-snapshot
3933
release-snapshot: ## Builds a snapshot release with goreleaser
40-
release-snapshot: buildx go-generate ; $(info $(M) building snapshot release $*)
34+
release-snapshot: go-generate ; $(info $(M) building snapshot release $*)
4135
goreleaser --verbose=$(GORELEASER_VERBOSE) \
4236
release \
4337
--snapshot \

0 commit comments

Comments
 (0)