feat: copy charts to pvc (#947)

**What problem does this PR solve?**:
Copies charts to a common pvc. 

Still missing:
- Special container that holds previous versions that would populate the
initial PVC for previous versions.

**Which issue(s) this PR fixes**:
Fixes #

**How Has This Been Tested?**:
<!--
Please describe the tests that you ran to verify your changes.
Provide output from the tests and any manual steps needed to replicate
the tests.
-->

**Special notes for your reviewer**:
<!--
Use this to provide any additional information to the reviewers.
This may include:
- Best way to review the PR.
- Where the author wants the most review attention on.
- etc.
-->

Author: faiq

.goreleaser.yml

@@ -109,6 +109,7 @@ dockers:
     build_flag_templates:
       - "--platform=linux/amd64"
       - "--pull"
+      - '--build-arg=VERSION=v{{ trimprefix .Version "v" }}'
       - "--label=org.opencontainers.image.created={{.CommitDate}}"
       - "--label=org.opencontainers.image.title=caren-helm-reg"
       - "--label=org.opencontainers.image.revision={{.FullCommit}}"
@@ -124,6 +125,7 @@ dockers:
     build_flag_templates:
       - "--platform=linux/arm64"
       - "--pull"
+      - '--build-arg=VERSION=v{{ trimprefix .Version "v" }}'
       - "--label=org.opencontainers.image.created={{.CommitDate}}"
       - "--label=org.opencontainers.image.title=caren-helm-reg"
       - "--label=org.opencontainers.image.revision={{.FullCommit}}"

charts/cluster-api-runtime-extensions-nutanix/templates/helm-repository.yaml

@@ -26,6 +26,21 @@ spec:
     kind: Issuer
   secretName: helm-repository-tls
 ---
+apiVersion: v1
+kind: PersistentVolumeClaim
+metadata:
+  finalizers:
+  - kubernetes.io/pvc-protection
+  name: helm-charts-pvc
+  namespace: {{ .Release.Namespace }}
+spec:
+  accessModes:
+  - ReadWriteOnce
+  resources:
+    requests:
+      storage: 2Gi
+  volumeMode: Filesystem
+---
 apiVersion: apps/v1
 kind: Deployment
 metadata:
@@ -45,6 +60,14 @@ spec:
       labels:
         app: helm-repository  # pods have this label, and Service and Deployment depend on it
     spec:
+      initContainers:
+      - name: copy-charts
+        image: "{{ .Values.helmRepositoryImage.repository }}:{{ default $.Chart.AppVersion .Values.helmRepositoryImage.tag }}"
+        command: ["/bin/sh", "-c", "cp /charts/*.tar /helm-charts"]
+        imagePullPolicy: "{{ .Values.image.pullPolicy }}"
+        volumeMounts:
+        - name: charts-volume
+          mountPath: "/helm-charts"
       containers:
       - name: helm-repository
         ports:
@@ -53,10 +76,22 @@ spec:
             containerPort: 5000
         image: "{{ .Values.helmRepositoryImage.repository }}:{{ default $.Chart.AppVersion .Values.helmRepositoryImage.tag }}"
         imagePullPolicy: "{{ .Values.image.pullPolicy }}"
+        command: ["/usr/bin/mindthegap"]
+        args:
+          - serve
+          - bundle
+          - --bundle=/helm-charts/helm-charts-*.tar
+          - --listen-port=5000
+          - --listen-address=0.0.0.0
+          - --tls-private-key-file=/certs/tls.key
+          - --tls-cert-file=/certs/tls.crt
         volumeMounts:
         - name: certs-vol
           mountPath: "/certs"
           readOnly: true
+        - name: charts-volume
+          mountPath: "/helm-charts"
+          readOnly: true
         livenessProbe:
           tcpSocket:
             port: serve
@@ -73,6 +108,9 @@ spec:
       - name: certs-vol
         secret:
           secretName: helm-repository-tls
+      - name: charts-volume
+        persistentVolumeClaim:
+          claimName: helm-charts-pvc
 ---
 apiVersion: v1
 kind: Service

hack/addons/mindthegap-helm-registry/Dockerfile

@@ -1,16 +1,12 @@
 ARG MINDTHEGAP_VERSION=v1.14.4
-
 FROM --platform=${BUILDPLATFORM} ghcr.io/mesosphere/mindthegap:${MINDTHEGAP_VERSION} as bundle_builder
 # this gets called by goreleaser so the copy source has to be the path relative to the repo root.
 RUN --mount=source=./hack/addons/mindthegap-helm-registry/repos.yaml,target=/repos.yaml \
     ["/ko-app/mindthegap", "create", "bundle", "--helm-charts-file=/repos.yaml", "--output-file=/tmp/helm-charts.tar"]
 
-FROM --platform=${TARGETPLATFORM} ghcr.io/mesosphere/mindthegap:${MINDTHEGAP_VERSION}
-COPY --from=bundle_builder /tmp/helm-charts.tar /tmp/helm-charts.tar
+FROM --platform=${TARGETPLATFORM} alpine:3.20.3
+ARG VERSION
+COPY --from=bundle_builder /tmp/helm-charts.tar /charts/helm-charts-${VERSION}.tar
+COPY --from=bundle_builder /ko-app/mindthegap /usr/bin/mindthegap
 VOLUME /certs
-CMD [ "serve", "bundle", \
-      "--bundle=/tmp/helm-charts.tar", \
-      "--listen-port=5000", \
-      "--listen-address=0.0.0.0", \
-      "--tls-private-key-file=/certs/tls.key", \
-      "--tls-cert-file=/certs/tls.crt" ]
+ENTRYPOINT /usr/bin/mindthegap