fixup! feat: Nutanix VM image preflight check

Address linter errors

Author: dlipovetsky

pkg/webhook/preflight/nutanix/nutanix.go renamed to pkg/webhook/preflight/nutanix/checker.go

@@ -20,15 +20,9 @@ import (
 type Checker struct {
 	client        ctrlclient.Client
 	nutanixClient *prismv4.Client
-	cluster       *clusterv1.Cluster
-	clusterConfig *variables.ClusterConfigSpec
 }
 
-func (n *Checker) Provider() string {
-	return "nutanix"
-}
-
-func (n *Checker) Checks(
+func (n *Checker) Init(
 	ctx context.Context,
 	client ctrlclient.Client,
 	cluster *clusterv1.Cluster,
@@ -54,7 +48,10 @@ func (n *Checker) Checks(
 	if clusterConfig.ControlPlane != nil && clusterConfig.ControlPlane.Nutanix != nil {
 		checks = append(
 			checks,
-			n.VMImageCheck(clusterConfig.ControlPlane.Nutanix.MachineDetails, "controlPlane.nutanix.machineDetails"),
+			n.VMImageCheck(
+				&clusterConfig.ControlPlane.Nutanix.MachineDetails,
+				"controlPlane.nutanix.machineDetails",
+			),
 		)
 	}
 
@@ -79,7 +76,7 @@ func (n *Checker) Checks(
 			}
 
 			n.VMImageCheck(
-				workerConfig.Nutanix.MachineDetails,
+				&workerConfig.Nutanix.MachineDetails,
 				fmt.Sprintf(
 					"workers.machineDeployments[.name=%s].variables.overrides[.name=workerConfig].value.nutanix.machineDetails",
 					md.Name,

pkg/webhook/preflight/nutanix/client.go

@@ -25,7 +25,7 @@ func newV4Client(
 	error,
 ) {
 	if clusterConfig.Nutanix.PrismCentralEndpoint.Credentials.SecretRef.Name == "" {
-		return nil, fmt.Errorf("Prism Central credentials reference SecretRef.Name has no value")
+		return nil, fmt.Errorf("prism Central credentials reference SecretRef.Name has no value")
 	}
 
 	credentialsSecret := &corev1.Secret{}
@@ -56,6 +56,5 @@ func newV4Client(
 		Username: credentials.Username,
 		Password: credentials.Password,
 		Insecure: clusterConfig.Nutanix.PrismCentralEndpoint.Insecure,
-		// TODO AdditionalTrustBundle
 	})
 }

pkg/webhook/preflight/nutanix/image.go

@@ -13,7 +13,7 @@ import (
 	"github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/pkg/webhook/preflight"
 )
 
-func (n *Checker) VMImageCheck(details carenv1.NutanixMachineDetails, field string) preflight.Check {
+func (n *Checker) VMImageCheck(details *carenv1.NutanixMachineDetails, field string) preflight.Check {
 	return func(ctx context.Context) preflight.CheckResult {
 		result := preflight.CheckResult{
 			Allowed: true,