feat: Build with go 1.23 (#889)

Author: jimmidyson

.goreleaser.yml

@@ -154,4 +154,4 @@ checksum:
   name_template: 'checksums.txt'
 
 snapshot:
-  name_template: "{{ incminor .Tag }}-dev"
+  version_template: "{{ incminor .Tag }}-dev"

api/go.mod

@@ -5,7 +5,7 @@ module github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/ap
 
 go 1.22.0
 
-toolchain go1.22.5
+toolchain go1.23.0
 
 replace github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/common => ../common
 

api/v1alpha1/nutanix_clusterconfig_types.go

@@ -55,11 +55,11 @@ type NutanixPrismCentralEndpointCredentials struct {
 }
 
 //nolint:gocritic // No need for named return values
-func (s NutanixPrismCentralEndpointSpec) ParseURL() (string, int32, error) {
+func (s NutanixPrismCentralEndpointSpec) ParseURL() (string, uint16, error) {
 	var prismCentralURL *url.URL
 	prismCentralURL, err := url.Parse(s.URL)
 	if err != nil {
-		return "", -1, fmt.Errorf("error parsing Prism Central URL: %w", err)
+		return "", 0, fmt.Errorf("error parsing Prism Central URL: %w", err)
 	}
 
 	hostname := prismCentralURL.Hostname()
@@ -69,10 +69,10 @@ func (s NutanixPrismCentralEndpointSpec) ParseURL() (string, int32, error) {
 		return hostname, DefaultPrismCentralPort, nil
 	}
 
-	port, err := strconv.ParseInt(prismCentralURL.Port(), 10, 32)
+	port, err := strconv.ParseUint(prismCentralURL.Port(), 10, 16)
 	if err != nil {
-		return "", -1, fmt.Errorf("error converting port to int: %w", err)
+		return "", 0, fmt.Errorf("error converting port to int: %w", err)
 	}
 
-	return hostname, int32(port), nil
+	return hostname, uint16(port), nil //nolint:gosec // Bounds are checked by ParseUint call above.
 }

common/go.mod

@@ -5,7 +5,7 @@ module github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/co
 
 go 1.22.0
 
-toolchain go1.22.5
+toolchain go1.23.0
 
 replace github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/api => ../api
 

devbox.json

@@ -16,7 +16,6 @@
     "golines@latest",
     "goreleaser@latest",
     "gotestsum@latest",
-    "govulncheck@latest",
     "helm-docs@latest",
     "hugo@latest",
     "kind@latest",
@@ -36,6 +35,7 @@
     "path:./hack/flakes#go-mod-upgrade",
     "path:./hack/flakes#golangci-lint",
     "path:./hack/flakes#goprintconst",
+    "path:./hack/flakes#govulncheck",
     "path:./hack/flakes#helm-with-plugins",
     "path:./hack/flakes#release-please",
     "path:./hack/flakes#setup-envtest"