fix(webhook): remove default workerConfig checks

Author: thunderboltsid

pkg/webhook/cluster/nutanix_validator.go

@@ -200,33 +200,6 @@ func validateWorkerFailureDomainConfig(
 			fmt.Errorf("failed to unmarshal cluster topology variable %q: %w", v1alpha1.WorkerConfigVariableName, err)))
 	}
 
-	// Check if control plane has failure domains configured - this affects default worker config validation
-	controlPlaneHasFailureDomains := false
-	if clusterConfig != nil && clusterConfig.ControlPlane != nil && clusterConfig.ControlPlane.Nutanix != nil {
-		controlPlaneHasFailureDomains = len(clusterConfig.ControlPlane.Nutanix.FailureDomains) > 0
-	}
-
-	// Validate default worker config when control plane has failure domains
-	if controlPlaneHasFailureDomains && defaultWorkerConfig != nil && defaultWorkerConfig.Nutanix != nil {
-		machineDetails := defaultWorkerConfig.Nutanix.MachineDetails
-		hasCluster := machineDetails.Cluster != nil &&
-			(machineDetails.Cluster.IsName() || machineDetails.Cluster.IsUUID())
-		hasSubnets := len(machineDetails.Subnets) > 0
-
-		if hasCluster {
-			fldErrs = append(fldErrs, field.Forbidden(
-				workerConfigVarPath.Child("value", "nutanix", "machineDetails", "cluster"),
-				"\"cluster\" must not be set when control plane failureDomains are configured.",
-			))
-		}
-		if hasSubnets {
-			fldErrs = append(fldErrs, field.Forbidden(
-				workerConfigVarPath.Child("value", "nutanix", "machineDetails", "subnets"),
-				"\"subnets\" must not be set when control plane failureDomains are configured.",
-			))
-		}
-	}
-
 	if cluster.Spec.Topology.Workers != nil {
 		for i := range cluster.Spec.Topology.Workers.MachineDeployments {
 			md := cluster.Spec.Topology.Workers.MachineDeployments[i]

pkg/webhook/cluster/nutanix_validator_test.go

@@ -362,14 +362,11 @@ func TestValidateTopologyFailureDomainConfig(t *testing.T) {
 			},
 		},
 		{
-			name:          "default workerConfig variable with cluster/subnets set when control plane has failureDomains violates XOR", //nolint:lll // name is long.
-			clusterConfig: fakeClusterConfigSpec(true, false, false),
-			cluster:       fakeCluster(t, false, true, true, workerConfigDefaultOnly),
-			expectedErr:   true,
-			expectedErrMessages: []string{
-				"spec.topology.variables.workerConfig.value.nutanix.machineDetails.cluster: Forbidden: \"cluster\" must not be set when control plane failureDomains are configured.", //nolint:lll // Message is long.
-				"spec.topology.variables.workerConfig.value.nutanix.machineDetails.subnets: Forbidden: \"subnets\" must not be set when control plane failureDomains are configured.", //nolint:lll // Message is long.
-			},
+			name:                "default workerConfig variable with cluster/subnets set when control plane has failureDomains should be allowed", //nolint:lll // name is long.
+			clusterConfig:       fakeClusterConfigSpec(true, false, false),
+			cluster:             fakeCluster(t, false, true, true, workerConfigDefaultOnly),
+			expectedErr:         false,
+			expectedErrMessages: nil,
 		},
 	}