minor changes

Author: vijayaraghavanr31

docs/content/addons/k8s-registration-agent.md

@@ -1,5 +1,5 @@
 +++
-title = " Kubernets cluster registration addon"
+title = "Kubernetes cluster registration addon"
 icon = "fa-solid fa-object-group"
 +++
 
@@ -26,5 +26,5 @@ spec:
             k8sRegistrationAgent: {}
 ```
 
-[Container Object Storage Interface]: https://github.com/nutanix-core/k8s-agent
+[Kubernetes cluster registration agent]: https://github.com/nutanix-core/k8s-agent
 [Cluster API Add-on Provider for Helm]: https://github.com/kubernetes-sigs/cluster-api-addon-provider-helm

pkg/handlers/generic/lifecycle/k8sregistrationagent/handler.go

@@ -44,7 +44,7 @@ func NewControllerConfig(globalOptions *options.GlobalOptions) *ControllerConfig
 	return &ControllerConfig{
 		GlobalOptions: globalOptions,
 		helmAddonConfig: addons.NewHelmAddonConfig(
-			"default-k8sRegistrationAgent--helm-values-template",
+			"default-k8s-registrationagent-helm-values-template",
 			defaultHelmReleaseNamespace,
 			defaultHelmReleaseName,
 		),
@@ -55,7 +55,7 @@ func (c *ControllerConfig) AddFlags(prefix string, flags *pflag.FlagSet) {
 	c.helmAddonConfig.AddFlags(prefix+".helm-addon", flags)
 }
 
-type DefaultK8sRegistrtionAgent struct {
+type DefaultK8sRegistrationAgent struct {
 	client              ctrlclient.Client
 	config              *ControllerConfig
 	helmChartInfoGetter *config.HelmChartGetter
@@ -65,17 +65,17 @@ type DefaultK8sRegistrtionAgent struct {
 }
 
 var (
-	_ commonhandlers.Named                   = &DefaultK8sRegistrtionAgent{}
-	_ lifecycle.AfterControlPlaneInitialized = &DefaultK8sRegistrtionAgent{}
-	_ lifecycle.BeforeClusterUpgrade         = &DefaultK8sRegistrtionAgent{}
+	_ commonhandlers.Named                   = &DefaultK8sRegistrationAgent{}
+	_ lifecycle.AfterControlPlaneInitialized = &DefaultK8sRegistrationAgent{}
+	_ lifecycle.BeforeClusterUpgrade         = &DefaultK8sRegistrationAgent{}
 )
 
 func New(
 	c ctrlclient.Client,
 	cfg *ControllerConfig,
 	helmChartInfoGetter *config.HelmChartGetter,
-) *DefaultK8sRegistrtionAgent {
-	return &DefaultK8sRegistrtionAgent{
+) *DefaultK8sRegistrationAgent {
+	return &DefaultK8sRegistrationAgent{
 		client:              c,
 		config:              cfg,
 		helmChartInfoGetter: helmChartInfoGetter,
@@ -84,11 +84,11 @@ func New(
 	}
 }
 
-func (n *DefaultK8sRegistrtionAgent) Name() string {
+func (n *DefaultK8sRegistrationAgent) Name() string {
 	return "K8sRegistrationAgentHandler"
 }
 
-func (n *DefaultK8sRegistrtionAgent) AfterControlPlaneInitialized(
+func (n *DefaultK8sRegistrationAgent) AfterControlPlaneInitialized(
 	ctx context.Context,
 	req *runtimehooksv1.AfterControlPlaneInitializedRequest,
 	resp *runtimehooksv1.AfterControlPlaneInitializedResponse,
@@ -99,7 +99,7 @@ func (n *DefaultK8sRegistrtionAgent) AfterControlPlaneInitialized(
 	resp.Message = commonResponse.GetMessage()
 }
 
-func (n *DefaultK8sRegistrtionAgent) BeforeClusterUpgrade(
+func (n *DefaultK8sRegistrationAgent) BeforeClusterUpgrade(
 	ctx context.Context,
 	req *runtimehooksv1.BeforeClusterUpgradeRequest,
 	resp *runtimehooksv1.BeforeClusterUpgradeResponse,
@@ -110,7 +110,7 @@ func (n *DefaultK8sRegistrtionAgent) BeforeClusterUpgrade(
 	resp.Message = commonResponse.GetMessage()
 }
 
-func (n *DefaultK8sRegistrtionAgent) apply(
+func (n *DefaultK8sRegistrationAgent) apply(
 	ctx context.Context,
 	cluster *clusterv1.Cluster,
 	resp *runtimehooksv1.CommonResponse,

pkg/handlers/generic/lifecycle/k8sregistrationagent/variables_test.go

@@ -5,20 +5,19 @@ import (
 	"testing"
 
 	"github.com/spf13/pflag"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 	corev1 "k8s.io/api/core/v1"
+	apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"
 	runtimehooksv1 "sigs.k8s.io/cluster-api/exp/runtime/hooks/api/v1alpha1"
 	"sigs.k8s.io/controller-runtime/pkg/client/fake"
 
-	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
-
 	"github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/api/v1alpha1"
 	"github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/pkg/handlers/generic/lifecycle/config"
 	"github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/pkg/handlers/options"
-	apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
 )
 
 var testScheme = runtime.NewScheme()
@@ -28,14 +27,14 @@ func init() {
 	_ = clusterv1.AddToScheme(testScheme)
 }
 
-func newTestHandler(t *testing.T) *DefaultK8sRegistrtionAgent {
+func newTestHandler(t *testing.T) *DefaultK8sRegistrationAgent {
 	t.Helper()
 
 	client := fake.NewClientBuilder().WithScheme(testScheme).Build()
 	cfg := NewControllerConfig(&options.GlobalOptions{})
 	getter := &config.HelmChartGetter{} // not used directly in test
 
-	return &DefaultK8sRegistrtionAgent{
+	return &DefaultK8sRegistrationAgent{
 		client:              client,
 		config:              cfg,
 		helmChartInfoGetter: getter,
@@ -69,8 +68,10 @@ func TestApply_FailsWhenCredentialsMissing(t *testing.T) {
 		Spec: clusterv1.ClusterSpec{
 			Topology: &clusterv1.Topology{
 				Variables: []clusterv1.ClusterVariable{{
-					Name:  v1alpha1.ClusterConfigVariableName,
-					Value: apiextensionsv1.JSON{Raw: []byte(`{"addons":{"k8sRegistrationAgent":{"strategy":"HelmAddon"}}}`)},
+					Name: v1alpha1.ClusterConfigVariableName,
+					Value: apiextensionsv1.JSON{
+						Raw: []byte(`{"addons":{"k8sRegistrationAgent":{"strategy":"HelmAddon"}}}`),
+					},
 				}},
 			},
 		},
@@ -571,7 +572,7 @@ func TestApply_SuccessfulWithFullNutanixConfig(t *testing.T) {
 	client := fake.NewClientBuilder().WithScheme(testScheme).Build()
 	cfg := NewControllerConfig(&options.GlobalOptions{})
 
-	handler := &DefaultK8sRegistrtionAgent{
+	handler := &DefaultK8sRegistrationAgent{
 		client:              client,
 		config:              cfg,
 		helmChartInfoGetter: &config.HelmChartGetter{},