fix: Use preflight check name as cause type

Previously, the "FailedPreflight" prefix was present, but it makes it
more difficult to identify the name of the check that failed, and the
prefix is not necessary, because the top-level Message explains that
preflight checks failed.

Author: dlipovetsky

pkg/webhook/preflight/preflight.go

@@ -131,11 +131,13 @@ func (h *WebhookHandler) Handle(ctx context.Context, req admission.Request) admi
 				resp.Allowed = false
 			}
 			for _, cause := range result.Causes {
-				resp.Result.Details.Causes = append(resp.Result.Details.Causes, metav1.StatusCause{
-					Type:    metav1.CauseType(fmt.Sprintf("FailedPreflight%s", result.Name)),
-					Message: cause.Message,
-					Field:   cause.Field,
-				})
+				resp.Result.Details.Causes = append(resp.Result.Details.Causes,
+					metav1.StatusCause{
+						Type:    metav1.CauseType(result.Name),
+						Message: cause.Message,
+						Field:   cause.Field,
+					},
+				)
 			}
 			resp.Warnings = append(resp.Warnings, result.Warnings...)
 		}

pkg/webhook/preflight/preflight_test.go

@@ -248,7 +248,7 @@ func TestHandle(t *testing.T) {
 						Details: &metav1.StatusDetails{
 							Causes: []metav1.StatusCause{
 								{
-									Type:    "FailedPreflightTest1",
+									Type:    "Test1",
 									Field:   "spec.test",
 									Message: "test failed",
 								},
@@ -342,11 +342,11 @@ func TestHandle(t *testing.T) {
 						Details: &metav1.StatusDetails{
 							Causes: []metav1.StatusCause{
 								{
-									Type:    "FailedPreflightTest2",
+									Type:    "Test2",
 									Message: "check failed",
 								},
 								{
-									Type:    "FailedPreflightTest1",
+									Type:    "Test1",
 									Message: "internal error",
 								},
 							},
@@ -475,11 +475,11 @@ func TestHandleCancelledContext(t *testing.T) {
 				Details: &metav1.StatusDetails{
 					Causes: []metav1.StatusCause{
 						{
-							Type:    "FailedPreflightTest1",
+							Type:    "Test1",
 							Message: "context cancelled",
 						},
 						{
-							Type:    "FailedPreflightTest2",
+							Type:    "Test2",
 							Message: "context cancelled",
 						},
 					},