fixup! feat(preflight): Add a check for storage containers

Fix ListStorageContainers filter format. Use single quotes. Also fix corresponding unit test.

Author: dlipovetsky

pkg/webhook/preflight/nutanix/storagecontainer.go

@@ -144,7 +144,7 @@ func getStorageContainer(
 		return nil, fmt.Errorf("failed to get cluster: %w", err)
 	}
 
-	fltr := fmt.Sprintf("name eq %q and clusterExtId eq %q", storageContainerName, *cluster.ExtId)
+	fltr := fmt.Sprintf("name eq '%s' and clusterExtId eq '%s'", storageContainerName, *cluster.ExtId)
 	resp, err := client.ListStorageContainers(nil, nil, &fltr, nil, nil)
 	if err != nil {
 		return nil, fmt.Errorf("failed to list storage containers: %w", err)

pkg/webhook/preflight/nutanix/storagecontainer_test.go

@@ -826,16 +826,16 @@ func TestStorageContainerCheck(t *testing.T) {
 					*clustermgmtv4.ListStorageContainersApiResponse,
 					error,
 				) {
-					// Simply return a container with the requested name
+					require.NotNil(t, filter)
+					// Extract name from filter
 					containerName := ""
-					if filter != nil {
-						// Extract name from filter
-						switch *filter {
-						case "name eq \"valid-container\" and clusterExtId eq \"cluster-uuid-123\"":
-							containerName = "valid-container"
-						case "name eq \"another-valid-container\" and clusterExtId eq \"cluster-uuid-123\"":
-							containerName = "another-valid-container"
-						}
+					switch *filter {
+					case "name eq 'valid-container' and clusterExtId eq 'cluster-uuid-123'":
+						containerName = "valid-container"
+					case "name eq 'another-valid-container' and clusterExtId eq 'cluster-uuid-123'":
+						containerName = "another-valid-container"
+					default:
+						return nil, fmt.Errorf("filter %q does not match any storage container", *filter)
 					}
 
 					resp := &clustermgmtv4.ListStorageContainersApiResponse{