fix: set topology webhook matchConditions (#1375)

**What problem does this PR solve?**:
Recently found a bug
#1372
This adds another level of safety and skips unnecessarily calling this
webhook for clusters not using topology.

**Which issue(s) this PR fixes**:
Fixes #

**How Has This Been Tested?**:
<!--
Please describe the tests that you ran to verify your changes.
Provide output from the tests and any manual steps needed to replicate
the tests.
-->

**Special notes for your reviewer**:
<!--
Use this to provide any additional information to the reviewers.
This may include:
- Best way to review the PR.
- Where the author wants the most review attention on.
- etc.
-->

Author: dkoshkin

charts/cluster-api-runtime-extensions-nutanix/templates/webhooks.yaml

@@ -27,6 +27,9 @@ webhooks:
         resources:
           - clusters
     sideEffects: None
+    matchConditions:
+      - name: has-topology
+        expression: has(object.spec.topology)
   - admissionReviewVersions:
       - v1
     clientConfig:
@@ -47,6 +50,9 @@ webhooks:
         resources:
           - clusters
     sideEffects: None
+    matchConditions:
+      - name: has-topology
+        expression: has(object.spec.topology)
 ---
 apiVersion: admissionregistration.k8s.io/v1
 kind: ValidatingWebhookConfiguration
@@ -75,6 +81,9 @@ webhooks:
         resources:
           - clusters
     sideEffects: None
+    matchConditions:
+      - name: has-topology
+        expression: has(object.spec.topology)
   - admissionReviewVersions:
       - v1
     clientConfig:
@@ -95,3 +104,6 @@ webhooks:
           - clusters
     sideEffects: None
     timeoutSeconds: 30
+    matchConditions:
+      - name: has-topology
+        expression: has(object.spec.topology)

hack/update-webhook-configurations.yq

@@ -7,8 +7,16 @@
 with(.metadata;
   .name = "{{ include \"chart.name\" . }}-" + .name,
   .annotations["cert-manager.io/inject-ca-from"] = "{{ .Release.Namespace}}/{{ template \"chart.name\" . }}-admission-tls"
-),
+) |
 with(.webhooks[].clientConfig.service;
   .name = "{{ include \"chart.name\" . }}-admission",
   .namespace = "{{ .Release.Namespace }}"
+) |
+with(.webhooks[];
+  .matchConditions = [
+    {
+      "name": "has-topology",
+      "expression": "has(object.spec.topology)"
+    }
+  ]
 )