feat: Build with go 1.23.3 and upgrade all tools (#967)

**What problem does this PR solve?**:

**Which issue(s) this PR fixes**:
Fixes #

**How Has This Been Tested?**:
<!--
Please describe the tests that you ran to verify your changes.
Provide output from the tests and any manual steps needed to replicate
the tests.
-->

**Special notes for your reviewer**:
<!--
Use this to provide any additional information to the reviewers.
This may include:
- Best way to review the PR.
- Where the author wants the most review attention on.
- etc.
-->

Author: jimmidyson

.github/workflows/checks.yml

@@ -66,9 +66,9 @@ jobs:
         config:
           - {"provider": "Nutanix", "kubernetesVersion": "v1.29.6", "osImage": "nkp-rocky-9.4-release-1.29.6-20240816215147"}
           - {"provider": "Nutanix", "kubernetesVersion": "v1.30.5", "osImage": "nkp-rocky-9.4-release-1.30.5-20240930171619"}
-          - {"provider": "Docker", "kubernetesVersion": "v1.29.8"}
-          - {"provider": "Docker", "kubernetesVersion": "v1.30.5"}
-          - {"provider": "Docker", "kubernetesVersion": "v1.31.0"}
+          - {"provider": "Docker", "kubernetesVersion": "v1.29.9"}
+          - {"provider": "Docker", "kubernetesVersion": "v1.30.6"}
+          - {"provider": "Docker", "kubernetesVersion": "v1.31.2"}
           # Uncomment below once we have the ability to run e2e tests on other providers from GHA.
           # - {"provider": "AWS", "kubernetesVersion": "v1.29.6"}
       fail-fast: false
@@ -95,9 +95,9 @@ jobs:
     strategy:
       matrix:
         config:
-          - {"provider": "Docker", "kubernetesVersion": "v1.29.8"}
-          - {"provider": "Docker", "kubernetesVersion": "v1.30.5"}
-          - {"provider": "Docker", "kubernetesVersion": "v1.31.0"}
+          - {"provider": "Docker", "kubernetesVersion": "v1.29.9"}
+          - {"provider": "Docker", "kubernetesVersion": "v1.30.6"}
+          - {"provider": "Docker", "kubernetesVersion": "v1.31.2"}
           # Uncomment below once we have the ability to run e2e tests on other providers from GHA.
           # - {"provider": "Nutanix", "kubernetesVersion": "v1.29.6"}
           # - {"provider": "AWS", "kubernetesVersion": "v1.29.6"}

.pre-commit-config.yaml

@@ -77,36 +77,36 @@ repos:
   rev: v4.6.0
   hooks:
   - id: trailing-whitespace
-    stages: [commit]
+    stages: [pre-commit]
   - id: check-yaml
     args: ["-m", "--unsafe"]
-    stages: [commit]
+    stages: [pre-commit]
     exclude: ^charts/.+/(templates|addons)/.+\.ya?ml$
   - id: mixed-line-ending
     args: ["-f", "lf"]
     exclude: \.bat$
-    stages: [commit]
+    stages: [pre-commit]
   - id: no-commit-to-branch
-    stages: [commit]
+    stages: [pre-commit]
   - id: check-added-large-files
-    stages: [commit]
+    stages: [pre-commit]
     exclude: ^pkg/handlers/cni/calico/manifests/tigera-operator-configmap.yaml$
   - id: check-case-conflict
-    stages: [commit]
+    stages: [pre-commit]
   - id: check-merge-conflict
-    stages: [commit]
+    stages: [pre-commit]
   - id: check-executables-have-shebangs
-    stages: [commit]
+    stages: [pre-commit]
   - id: check-symlinks
-    stages: [commit]
+    stages: [pre-commit]
   - id: end-of-file-fixer
-    stages: [commit]
+    stages: [pre-commit]
     exclude: ^charts/cluster-api-runtime-extensions-nutanix/README.md$
 - repo: https://github.com/rhysd/actionlint
   rev: v1.7.1
   hooks:
   - id: actionlint-system
-    stages: [commit]
+    stages: [pre-commit]
 - repo: https://github.com/jorisroovers/gitlint
   rev: v0.19.1
   hooks:
@@ -117,28 +117,28 @@ repos:
   rev: 3.0.0
   hooks:
   - id: shfmt
-    stages: [commit]
+    stages: [pre-commit]
     args: ["-s", "-i", "2"]
   - id: script-must-have-extension
-    stages: [commit]
+    stages: [pre-commit]
 - repo: https://github.com/shellcheck-py/shellcheck-py
   rev: v0.10.0.1
   hooks:
   - id: shellcheck
-    stages: [commit]
+    stages: [pre-commit]
     args: ["-e", "SC2211", "-x"]
 - repo: https://github.com/igorshubovych/markdownlint-cli
   rev: v0.41.0
   hooks:
   - id: markdownlint
-    stages: [commit]
+    stages: [pre-commit]
     exclude: ^(CHANGELOG.md|charts/.+/README.md|.github/pull_request_template.md)$
 - repo: https://github.com/Lucas-C/pre-commit-hooks
   rev: v1.5.5
   hooks:
   - id: insert-license
     name: License headers - Go
-    stages: [commit]
+    stages: [pre-commit]
     files: "(.*\\.go|go.mod)$"
     exclude: ^(api/external/|internal/test)
     args:
@@ -149,7 +149,7 @@ repos:
       - --allow-past-years
   - id: insert-license
     name: License headers - YAML and Makefiles
-    stages: [commit]
+    stages: [pre-commit]
     files: (^Makefile|\.(ya?ml|mk))$
     exclude: ^(internal/test|pkg/handlers/.+/embedded|examples|charts/cluster-api-runtime-extensions-nutanix/(defaultclusterclasses|addons))/.+\.ya?ml|docs/static/helm/index\.yaml|charts/cluster-api-runtime-extensions-nutanix/templates/helm-config.yaml$
     args:
@@ -158,7 +158,7 @@ repos:
       - --allow-past-years
   - id: insert-license
     name: License headers - Markdown
-    stages: [commit]
+    stages: [pre-commit]
     files: \.md$
     exclude: ^(CHANGELOG.md$|docs/|.github/pull_request_template.md$)
     args:

api/go.mod

@@ -5,7 +5,7 @@ module github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/ap
 
 go 1.22.0
 
-toolchain go1.23.1
+toolchain go1.23.3
 
 replace github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/common => ../common
 

api/v1alpha1/crds/caren.nutanix.com_awsclusterconfigs.yaml

@@ -5,7 +5,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: (devel)
+    controller-gen.kubebuilder.io/version: v0.16.4
   name: awsclusterconfigs.caren.nutanix.com
 spec:
   group: caren.nutanix.com

api/v1alpha1/crds/caren.nutanix.com_awsworkernodeconfigs.yaml

@@ -5,7 +5,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: (devel)
+    controller-gen.kubebuilder.io/version: v0.16.4
   name: awsworkernodeconfigs.caren.nutanix.com
 spec:
   group: caren.nutanix.com

api/v1alpha1/crds/caren.nutanix.com_dockerclusterconfigs.yaml

@@ -5,7 +5,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: (devel)
+    controller-gen.kubebuilder.io/version: v0.16.4
   name: dockerclusterconfigs.caren.nutanix.com
 spec:
   group: caren.nutanix.com

api/v1alpha1/crds/caren.nutanix.com_dockernodeconfigs.yaml

@@ -5,7 +5,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: (devel)
+    controller-gen.kubebuilder.io/version: v0.16.4
   name: dockernodeconfigs.caren.nutanix.com
 spec:
   group: caren.nutanix.com

api/v1alpha1/crds/caren.nutanix.com_genericclusterconfigs.yaml

@@ -5,7 +5,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: (devel)
+    controller-gen.kubebuilder.io/version: v0.16.4
   name: genericclusterconfigs.caren.nutanix.com
 spec:
   group: caren.nutanix.com

api/v1alpha1/crds/caren.nutanix.com_nutanixclusterconfigs.yaml

@@ -5,7 +5,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: (devel)
+    controller-gen.kubebuilder.io/version: v0.16.4
   name: nutanixclusterconfigs.caren.nutanix.com
 spec:
   group: caren.nutanix.com

api/v1alpha1/crds/caren.nutanix.com_nutanixnodeconfigs.yaml

@@ -5,7 +5,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: (devel)
+    controller-gen.kubebuilder.io/version: v0.16.4
   name: nutanixnodeconfigs.caren.nutanix.com
 spec:
   group: caren.nutanix.com