fixup! feat: adds cluster's ownerref on cilium helm values source object

Author: dkoshkin

pkg/handlers/generic/lifecycle/ccm/nutanix/handler.go

@@ -88,7 +88,7 @@ func (p *provider) Apply(
 		err := handlersutils.EnsureClusterOwnerReferenceForObject(
 			ctx,
 			p.client,
-			&corev1.TypedLocalObjectReference{
+			corev1.TypedLocalObjectReference{
 				Kind: "Secret",
 				Name: clusterConfig.Addons.CCM.Credentials.SecretRef.Name,
 			},

pkg/handlers/generic/lifecycle/cni/cilium/handler.go

@@ -189,7 +189,7 @@ func (c *CiliumCNI) apply(
 			err := handlersutils.EnsureClusterOwnerReferenceForObject(
 				ctx,
 				c.client,
-				&corev1.TypedLocalObjectReference{
+				corev1.TypedLocalObjectReference{
 					Kind: cniVar.Values.SourceRef.Kind,
 					Name: cniVar.Values.SourceRef.Name,
 				},

pkg/handlers/generic/lifecycle/csi/nutanix/handler.go

@@ -112,7 +112,7 @@ func (n *NutanixCSI) Apply(
 		err := handlersutils.EnsureClusterOwnerReferenceForObject(
 			ctx,
 			n.client,
-			&corev1.TypedLocalObjectReference{
+			corev1.TypedLocalObjectReference{
 				Kind: "Secret",
 				Name: provider.Credentials.SecretRef.Name,
 			},

pkg/handlers/generic/mutation/imageregistries/credentials/inject.go

@@ -291,7 +291,7 @@ func ensureOwnerReferenceOnCredentialsSecrets(
 			err := handlersutils.EnsureClusterOwnerReferenceForObject(
 				ctx,
 				c,
-				&corev1.TypedLocalObjectReference{
+				corev1.TypedLocalObjectReference{
 					Kind: "Secret",
 					Name: secretName,
 				},

pkg/handlers/utils/secrets.go

@@ -70,7 +70,7 @@ func CopySecretToRemoteCluster(
 func EnsureClusterOwnerReferenceForObject(
 	ctx context.Context,
 	cl ctrlclient.Client,
-	objectRef *corev1.TypedLocalObjectReference,
+	objectRef corev1.TypedLocalObjectReference,
 	cluster *clusterv1.Cluster,
 ) error {
 	targetObj, err := GetResourceFromTypedLocalObjectReference(
@@ -99,7 +99,7 @@ func EnsureClusterOwnerReferenceForObject(
 func GetResourceFromTypedLocalObjectReference(
 	ctx context.Context,
 	cl ctrlclient.Client,
-	typedLocalObjectRef *corev1.TypedLocalObjectReference,
+	typedLocalObjectRef corev1.TypedLocalObjectReference,
 	ns string,
 ) (*unstructured.Unstructured, error) {
 	apiVersion := corev1.SchemeGroupVersion.String()

pkg/handlers/utils/secrets_test.go

@@ -117,7 +117,7 @@ func Test_EnsureOwnerReferenceForSecret(t *testing.T) {
 			err := EnsureClusterOwnerReferenceForObject(
 				context.Background(),
 				tt.client,
-				&corev1.TypedLocalObjectReference{
+				corev1.TypedLocalObjectReference{
 					Kind: "Secret",
 					Name: tt.secretName,
 				},