Skip to content

Conversation

@dkoshkin
Copy link
Contributor

@dkoshkin dkoshkin commented Jun 2, 2025

What problem does this PR solve?:
Updating the handler version and removing the previous controlplanevirtualip/providers/kubevip.go handler implementation.

Which issue(s) this PR fixes:
Fixes #

How Has This Been Tested?:

Special notes for your reviewer:

@dkoshkin dkoshkin force-pushed the dkoshkin/feat-update-handler-version branch 2 times, most recently from f7fd68e to e840dae Compare June 2, 2025 15:45
Copy link
Member

@jimmidyson jimmidyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jimmidyson jimmidyson enabled auto-merge (squash) June 3, 2025 15:07
dkoshkin added 5 commits June 3, 2025 09:37
# Conflicts:
#	pkg/handlers/v2/generic/mutation/controlplanevirtualip/inject_test.go
#	pkg/handlers/v2/generic/mutation/controlplanevirtualip/providers/kubevip_test.go
We no longer have handler specific flags, so no need to call AddFlags()
@dkoshkin dkoshkin force-pushed the dkoshkin/feat-update-handler-version branch from 4cf5cdc to ad996c4 Compare June 3, 2025 16:37
@jimmidyson jimmidyson merged commit 5890b05 into main Jun 3, 2025
22 checks passed
@jimmidyson jimmidyson deleted the dkoshkin/feat-update-handler-version branch June 3, 2025 17:26
@github-actions github-actions bot mentioned this pull request Jun 3, 2025
jimmidyson added a commit that referenced this pull request Jun 3, 2025
Using the previously established pattern for retaining previous
handler functionality for existing clusters.

Requires #1144.
dkoshkin added a commit that referenced this pull request Jun 3, 2025
🤖 I have created a release *beep* *boop*
---


## 0.29.0 (2025-06-03)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

## What's Changed
### Exciting New Features 🎉
* feat: Explicitly disable profiling for CP components by @jimmidyson in
#1109
* feat: add registry addon by @dkoshkin in
#1116
* feat: use registryMirror addon as Containerd mirror by @dkoshkin in
#1117
* feat: Add k8s version logic for external cloud-provider flag by
@jimmidyson in
#1134
* feat: Update all addon versions by @jimmidyson in
#1139
* feat: generate a self-signed cert for registry addon by @dkoshkin in
#1127
* feat: CIS benchmark improvements by @jimmidyson in
#1137
* feat: update handler version by @dkoshkin in
#1144
### Fixes 🔧
* fix: uses consistent spelling by @faiq in
#1115
* fix: Ensure metallb speaker runs on tainted nodepools by @jimmidyson
in
#1138
* fix: Avoid rollout due to updated auditpolicy handler by @jimmidyson
in
#1147
### Other Changes
* ci: include correct kube-vip version when listing images by @dkoshkin
in
#1113
* build: Update all tools and fix up for golangci-lint v2 by @jimmidyson
in
#1108
* test(e2e): Disable Calico tests by @jimmidyson in
#1120
* test(e2e): Update Nutanix images by @jimmidyson in
#1121
* refactor: Register types with scheme using pattern from Cluster API by
@dlipovetsky in
#1124
* ci: use templating for capx tests by @faiq in
#1123
* test: Return root module root dir when using go.work by @dlipovetsky
in
#1125
* build: Update Docker k8s versions by @jimmidyson in
#1133
* refactor: Remove unnecessary loop vars by @jimmidyson in
#1146


**Full Changelog**:
v0.28.2...v0.29.0

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants