fix: Do not run preflight checks if Cluster is paused #1181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
approved these changes
Jun 24, 2025
supershal
approved these changes
Jun 25, 2025
This was referenced Jul 3, 2025
Closed
Merged
dlipovetsky
pushed a commit
that referenced
this pull request
Jul 4, 2025
🤖 I have created a release *beep* *boop* --- ## 0.31.0 (2025-07-03) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Allow configuration of kube-proxy mode on cluster creation by @jimmidyson in #1163 * feat: auto enable registry addon in workload clusters by @dkoshkin in #1175 * feat(ntp): Configure NTP for clusters by @thunderboltsid in #1185 * feat: adds a generic checker package with registry and mirror checks by @faiq in #1186 * feat: deploy registry syncer for workload clusters by @dkoshkin in #1189 * feat(preflight): Add VM Image kubernetes version check by @thunderboltsid in #1172 * feat: CAREN support for NutanixFailureDomain by @yanhua121 in #1192 ### Fixes 🔧 * fix: Do not run preflight checks if Cluster is paused by @dlipovetsky in #1181 * fix: misc fixes to the preflight framework by @dlipovetsky in #1188 * fix(preflight): improved error reporting for storage container and VM image checks by @thunderboltsid in #1180 * fix(file): rename test/request/capa.go and test/request/capx.go by @thunderboltsid in #1193 * fix: Move preflight skip annotation constants to api module by @dlipovetsky in #1187 * fix: Include correct field name in registry preflight check results by @dlipovetsky in #1194 * fix: add tolerations and nodeAffinity overrides for registry addon by @supershal in #1183 * fix: include GenericNodeSpec in aggregate type by @dkoshkin in #1182 * fix: Do not treat expected preflight check failures as internal errors by @dlipovetsky in #1195 ## New Contributors * @yanhua121 made their first contribution in #1192 **Full Changelog**: v0.30.0...v0.31.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
When clusterctl moves the Cluster, clusterctl first creates a paused Cluster object, then the referenced Secrets. That order might be a bug. However, to allow move to work, we want to skip preflight checks.
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer: