Skip to content

Conversation

@thunderboltsid
Copy link
Contributor

@thunderboltsid thunderboltsid commented Jun 26, 2025

  • Add API for configuring NTP servers
  • Add mutation handlers for injecting NTP servers

How has this been tested?

  • Create a cluster with custom NTP configuration
apiVersion: cluster.x-k8s.io/v1beta1
kind: Cluster
metadata:
  annotations:
    caren.nutanix.com/cluster-uuid: 0197a351-97fa-7b0c-88a7-aa83fb309884
  labels:
    cluster.x-k8s.io/provider: nutanix
    konvoy.d2iq.io/cluster-name: nkp-sid
    konvoy.d2iq.io/provider: nutanix
  name: nkp-sid
  namespace: default
spec:
  clusterNetwork:
    pods:
      cidrBlocks:
      - 192.168.0.0/16
    services:
      cidrBlocks:
      - 10.96.0.0/12
  controlPlaneEndpoint:
    host: ""
    port: 0
  topology:
    class: nutanix-quick-start
    controlPlane:
      metadata: {}
      replicas: 3
    variables:
    - name: clusterConfig
      value:
        ...
        ntp:
          servers:
          - time.google.com
  • Observe the kubeadmconfigs for machines have NTP Server set correctly
$ k get kubeadmconfigs -o yaml | grep ntp -A 3
    ntp:
      enabled: true
      servers:
      - time.google.com
--
    ntp:
      enabled: true
      servers:
      - time.google.com
--
    ntp:
      enabled: true
      servers:
      - time.google.com
--
    ntp:
      enabled: true
      servers:
      - time.google.com
--
    ntp:
      enabled: true
      servers:
      - time.google.com
  • Update the ntp config to point to a different NTP server and observe a machine rollout with new kubeadmconfigs set to the new NTP server
$ k get kubeadmconfigs -o yaml | grep ntp -A 3
    ntp:
      enabled: true
      servers:
      - time.aws.com
--
    ntp:
      enabled: true
      servers:
      - time.aws.com
--
    ntp:
      enabled: true
      servers:
      - time.aws.com
--
    ntp:
      enabled: true
      servers:
      - time.aws.com
--
    ntp:
      enabled: true
      servers:
      - time.aws.com

Copy link
Contributor

@dkoshkin dkoshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Copy link
Contributor

@dlipovetsky dlipovetsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thunderboltsid thunderboltsid merged commit 2007a42 into main Jun 30, 2025
22 checks passed
@thunderboltsid thunderboltsid deleted the issue/ntp branch June 30, 2025 16:05
This was referenced Jul 3, 2025
dlipovetsky pushed a commit that referenced this pull request Jul 4, 2025
🤖 I have created a release *beep* *boop*
---


## 0.31.0 (2025-07-03)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

## What's Changed
### Exciting New Features 🎉
* feat: Allow configuration of kube-proxy mode on cluster creation by
@jimmidyson in
#1163
* feat: auto enable registry addon in workload clusters by @dkoshkin in
#1175
* feat(ntp): Configure NTP for clusters by @thunderboltsid in
#1185
* feat: adds a generic checker package with registry and mirror checks
by @faiq in
#1186
* feat: deploy registry syncer for workload clusters by @dkoshkin in
#1189
* feat(preflight): Add VM Image kubernetes version check by
@thunderboltsid in
#1172
* feat: CAREN support for NutanixFailureDomain by @yanhua121 in
#1192
### Fixes 🔧
* fix: Do not run preflight checks if Cluster is paused by @dlipovetsky
in
#1181
* fix: misc fixes to the preflight framework by @dlipovetsky in
#1188
* fix(preflight): improved error reporting for storage container and VM
image checks by @thunderboltsid in
#1180
* fix(file): rename test/request/capa.go and test/request/capx.go by
@thunderboltsid in
#1193
* fix: Move preflight skip annotation constants to api module by
@dlipovetsky in
#1187
* fix: Include correct field name in registry preflight check results by
@dlipovetsky in
#1194
* fix: add tolerations and nodeAffinity overrides for registry addon by
@supershal in
#1183
* fix: include GenericNodeSpec in aggregate type by @dkoshkin in
#1182
* fix: Do not treat expected preflight check failures as internal errors
by @dlipovetsky in
#1195

## New Contributors
* @yanhua121 made their first contribution in
#1192

**Full Changelog**:
v0.30.0...v0.31.0

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants