ci(nvm): use NodeJS 16, 18, and 19 for verification

Author: nutgaard

.github/workflows/master.yaml

@@ -11,11 +11,15 @@ jobs:
   test-build-publish:
     name: Test and build
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node: [ 16, 18, 19 ]
     steps:
       - uses: actions/checkout@v1
       - uses: actions/setup-node@v3
+        name: Setup node ${{ matrix.node }}
         with:
-          node-version: 16
+          node-version: ${{ matrix.node }}
           cache: 'npm'
       - name: Install dependencies
         run: npm ci
@@ -24,14 +28,17 @@ jobs:
       - name: Build
         run: npm run build
       - name: Report coverage
+        if: ${{ matrix.node == '18' }}
         uses: codecov/codecov-action@v3
       - name: Publish docs
+        if: ${{ matrix.node == '18' }}
         uses: crazy-max/ghaction-github-pages@v2
         with:
           build_dir: docs
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: Publish package
+        if: ${{ matrix.node == '18' }}
         run: npx semantic-release
         env:
           GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}

.github/workflows/pr.yaml

@@ -11,11 +11,15 @@ jobs:
   test-and-build:
     name: Test and build
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node: [16, 18, 19]
     steps:
       - uses: actions/checkout@v1
       - uses: actions/setup-node@v3
+        name: Setup node ${{ matrix.node }}
         with:
-          node-version: 16
+          node-version: ${{ matrix.node }}
           cache: 'npm'
       - name: Install dependencies
         run: npm ci
@@ -24,4 +28,5 @@ jobs:
       - name: Build
         run: npm run build
       - name: Report coverage
+        if: ${{ matrix.node == '18' }}
         uses: codecov/codecov-action@v3

package.json

@@ -37,6 +37,7 @@
     "build:lib": "tsc -b ./tsconfig.cjs.json ./tsconfig.esm.json ./tsconfig.types.json",
     "build:docs": "typedoc --out docs src/yet-another-fetch-mock.ts",
     "test": "vitest run --coverage",
+    "testdev": "vitest watch --coverage ",
     "commit": "git-cz",
     "precommit": "lint-staged",
     "prepush": "npm run test && npm run build",

src/matcher-utils.ts

@@ -1,6 +1,5 @@
 import { HttpMethod, MatcherUrl, RequestUrl, RouteMatcher } from './types.js';
 import { createUrlRegex, findRequestMethod, findRequestUrl } from './internal-utils.js';
-import { pathToRegexp, Key } from 'path-to-regexp';
 
 const heuristics = [/\?\w=\w/, /\&\w=\w/, /\?\w$/, /\&\w$/];
 function containsQueryParams(matcherUrl: string): boolean {