Skip to content

Commit 75c876e

Browse files
committed
fixup!(ci): Run create-dmg until it succeeds
This properly stores the result of the increment operation in a variable, where previously that evaluation could return 1 and mess up with the exit status of this build step. That would happen when create-dmg failed in the first try, but succeeded in the next one. I've also added "set -x" to enable Bash's command tracing, making it easier to spot how many times create-dmg gets invoked.
1 parent 79170cc commit 75c876e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.github/workflows/macos.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,7 @@ jobs:
186186
187187
- name: Build dmg (${{ matrix.build-type }})
188188
run: |
189+
set -x
189190
cd build
190191
# FIXME: Undo this overengineered crap once the following issue gets figured out:
191192
# https://github.com/actions/runner-images/issues/7522
@@ -211,7 +212,7 @@ jobs:
211212
echo 'Error: create-dmg did not succeed even after 10 tries.'
212213
exit 1
213214
fi
214-
((i++))
215+
i=$((i+1))
215216
done
216217
217218
- name: Notarize

0 commit comments

Comments
 (0)