Skip to content

Commit e053408

Browse files
committed
Fix memory leaks in ListViewLogic and m_databuffer
1 parent 30024ac commit e053408

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/mainwindow.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ MainWindow::MainWindow(QWidget *parent)
129129
"master/notes_purchase_data.json")),
130130
m_purchaseDataAlt2(
131131
QStringLiteral("https://www.rubymamistvalove.com/notes/notes_purchase_data.json")),
132-
m_dataBuffer(new QByteArray()),
132+
m_dataBuffer(std::make_unique<QByteArray>()),
133133
m_netManager(new QNetworkAccessManager(this)),
134134
m_reqAlt1(QNetworkRequest(QUrl(m_purchaseDataAlt1))),
135135
m_reqAlt2(QNetworkRequest(QUrl(m_purchaseDataAlt2))),
@@ -1737,12 +1737,12 @@ void MainWindow::setupDatabases()
17371737
void MainWindow::setupModelView()
17381738
{
17391739
m_listView = ui->listView;
1740-
m_tagPool = new TagPool(m_dbManager);
1740+
m_tagPool = new TagPool(m_dbManager, this);
17411741
m_listModel = new NoteListModel(m_listView);
17421742
m_listView->setTagPool(m_tagPool);
17431743
m_listView->setModel(m_listModel);
17441744
m_listViewLogic = new ListViewLogic(m_listView, m_listModel, m_searchEdit, m_clearButton,
1745-
m_tagPool, m_dbManager, this);
1745+
m_tagPool, m_dbManager, m_listView);
17461746
m_treeView = ui->treeView;
17471747
m_treeView->setModel(m_treeModel);
17481748
m_treeViewLogic = new TreeViewLogic(m_treeView, m_treeModel, m_dbManager, m_listView, this);

src/mainwindow.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ public slots:
262262
QWindow *m_subscriptionWindow;
263263
QString m_purchaseDataAlt1;
264264
QString m_purchaseDataAlt2;
265-
QByteArray *m_dataBuffer;
265+
std::unique_ptr<QByteArray> m_dataBuffer;
266266
QNetworkAccessManager *m_netManager;
267267
QNetworkRequest m_reqAlt1;
268268
QNetworkRequest m_reqAlt2;

0 commit comments

Comments
 (0)