Skip to content

Commit 1febcb8

Browse files
chore: fix lint errors (#920)
* chore(eslint): update .eslintignore * chore: fix Vue component ordering * Adopt correct unused vars for typescript * chore: suppress specific errors instead of ignore file Co-authored-by: Brendan Mulholland <[email protected]>
1 parent 035aa86 commit 1febcb8

File tree

4 files changed

+15
-9
lines changed

4 files changed

+15
-9
lines changed

.eslintignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ templates/
22
node_modules
33
.nuxt
44
dist
5-
types
5+
docs/static/sw.js

.eslintrc

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@
44
],
55
"rules": {
66
"require-await": 0,
7-
"no-useless-constructor": 0
7+
"no-useless-constructor": 0,
8+
// Correct support for unused var detection in Typescript:
9+
// https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-unused-vars.md
10+
"no-unused-vars": "off",
11+
"@typescript-eslint/no-unused-vars": ["error"]
812
}
913
}

demo/pages/login.vue

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -110,18 +110,12 @@
110110
</div>
111111
</template>
112112

113-
<style scoped>
114-
.login-button {
115-
border: 0;
116-
}
117-
</style>
118-
119113
<script>
120114
import busyOverlay from '~/components/busy-overlay'
121115
122116
export default {
123-
middleware: ['auth'],
124117
components: { busyOverlay },
118+
middleware: ['auth'],
125119
data () {
126120
return {
127121
username: '',
@@ -251,3 +245,9 @@ export default {
251245
}
252246
}
253247
</script>
248+
249+
<style scoped>
250+
.login-button {
251+
border: 0;
252+
}
253+
</style>

src/index.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,14 @@ declare module 'vue/types/vue' {
5858
}
5959

6060
declare module 'vue/types/options' {
61+
// eslint-disable-next-line @typescript-eslint/no-unused-vars
6162
interface ComponentOptions<V extends Vue> {
6263
auth?: true | false | 'guest';
6364
}
6465
}
6566

6667
declare module 'vuex/types/index' {
68+
// eslint-disable-next-line @typescript-eslint/no-unused-vars
6769
interface Store<S> {
6870
$auth: Auth;
6971
}

0 commit comments

Comments
 (0)