Skip to content

Commit fbb4a7d

Browse files
committed
fix(config): made "databaseUrl" config value optional
re #458
1 parent 379c99c commit fbb4a7d

File tree

5 files changed

+3
-6
lines changed

5 files changed

+3
-6
lines changed

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ modules: [
4646
config: {
4747
apiKey: '<apiKey>',
4848
authDomain: '<authDomain>',
49-
databaseURL: '<databaseURL>',
5049
projectId: '<projectId>',
5150
storageBucket: '<storageBucket>',
5251
messagingSenderId: '<messagingSenderId>',

docs/content/en/guide/getting-started.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ modules: [
6363
config: {
6464
apiKey: '<apiKey>',
6565
authDomain: '<authDomain>',
66-
databaseURL: '<databaseURL>',
6766
projectId: '<projectId>',
6867
storageBucket: '<storageBucket>',
6968
messagingSenderId: '<messagingSenderId>',

docs/content/en/guide/options.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ config: {
1818
// REQUIRED: Official config for firebase.initializeApp(config):
1919
apiKey: '<apiKey>',
2020
authDomain: '<authDomain>',
21-
databaseURL: '<databaseURL>',
2221
projectId: '<projectId>',
2322
storageBucket: '<storageBucket>',
2423
messagingSenderId: '<messagingSenderId>',
@@ -97,7 +96,7 @@ config: {
9796
foofoofoo: {
9897
apiKey: '<apiKey>',
9998
authDomain: '<authDomain>',
100-
databaseURL: '<databaseURL>',
99+
databaseURL: '<databaseURL>', // Optional
101100
projectId: '<projectId>',
102101
storageBucket: '<storageBucket>',
103102
messagingSenderId: '<messagingSenderId>',

lib/module.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ function validateConfigKeys (options, currentEnv) {
284284
const requiredKeys = [
285285
'apiKey',
286286
'authDomain',
287-
'databaseURL',
287+
// 'databaseURL', // legacy, only available in old projects
288288
'projectId',
289289
'storageBucket',
290290
'messagingSenderId',

types/index.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { auth } from 'firebase-admin'
1313
export interface FirebaseConfiguration {
1414
apiKey: string
1515
authDomain: string
16-
databaseURL: string
16+
databaseURL?: string
1717
projectId: string
1818
storageBucket: string
1919
messagingSenderId: string

0 commit comments

Comments
 (0)