Skip to content

Commit 08d7e6c

Browse files
authored
fix: gracefully handle Nuxt versions without Runtime Config (#472)
1 parent 2d2b3ab commit 08d7e6c

File tree

3 files changed

+4
-1
lines changed

3 files changed

+4
-1
lines changed

docs/content/en/sentry/options.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ Normally, just setting DSN would be enough.
123123
- Default: `sentry`
124124
- Specified object in Nuxt config in `publicRuntimeConfig[runtimeConfigKey]` will override some options at runtime. See documentation at https://nuxtjs.org/docs/2.x/configuration-glossary/configuration-runtime-config/
125125
- Used to define the environment at runtime for example
126+
- See also [Runtime Config](/sentry/runtime-config) documentation.
126127
127128
### disabled
128129

docs/content/en/sentry/runtime-config.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,3 +28,5 @@ publicRuntimeConfig: {
2828
```
2929

3030
You can customize the key that is used to access settings from `publicRuntimeConfig` by setting [`runtimeConfigKey`](/sentry/options#runtimeconfigkey) in the non-runtime options.
31+
32+
This functionality is supported from Nuxt 2.13 and up.

lib/core/options.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ export async function resolveServerOptions (moduleContainer, moduleOptions, logg
233233
function getRuntimeConfig (moduleContainer, options) {
234234
const { publicRuntimeConfig } = moduleContainer.options
235235
const { runtimeConfigKey } = options
236-
if (typeof (publicRuntimeConfig) !== 'function' && runtimeConfigKey in publicRuntimeConfig) {
236+
if (publicRuntimeConfig && typeof (publicRuntimeConfig) !== 'function' && runtimeConfigKey in publicRuntimeConfig) {
237237
return merge(options.config, publicRuntimeConfig[runtimeConfigKey].config, publicRuntimeConfig[runtimeConfigKey].serverConfig)
238238
}
239239
}

0 commit comments

Comments
 (0)