fix: add missing stylesheet rel for prefetch tags (#23)

Robin Scholz · web-flow · commit d2ec8a3740e2 · 2022-01-11T20:39:28.000+01:00
diff --git a/src/renderer.ts b/src/renderer.ts
@@ -336,7 +336,7 @@ export function renderPreloadLinks (ssrContext: SSRContext, rendererContext: Ren
 export function renderPrefetchLinks (ssrContext: SSRContext, rendererContext: RendererContext): string {
   const { prefetch } = getRequestDependencies(ssrContext, rendererContext)
   return Object.values(prefetch).map(({ path }) =>
-    `<link ${isModule(path) ? 'type="module" ' : ''}rel="prefetch" href="${rendererContext.publicPath}${path}">`
+    `<link ${isModule(path) ? 'type="module" ' : ''}rel="prefetch${isCSS(path) ? ' stylesheet' : ''}" href="${rendererContext.publicPath}${path}">`
   ).join('')
 }
 
diff --git a/test/renderer.test.ts b/test/renderer.test.ts
@@ -79,7 +79,7 @@ describe('renderer with legacy manifest', () => {
     const result = renderResourceHints().split('>').slice(0, -1).map(s => `${s}>`).sort()
     expect(result).to.deep.equal(
       [
-        '<link rel="prefetch" href="/_nuxt/pages/another.css">', // dynamic import CSS
+        '<link rel="prefetch stylesheet" href="/_nuxt/pages/another.css">', // dynamic import CSS
         '<link rel="prefetch" href="/_nuxt/pages/another.js">', // dynamic import
         '<link rel="preload" href="/_nuxt/app.css" as="style">', // entrypoint CSS
         '<link rel="preload" href="/_nuxt/app.js" as="script">',

Original file line number	Diff line number	Diff line change
`@@ -336,7 +336,7 @@ export function renderPreloadLinks (ssrContext: SSRContext, rendererContext: Ren`
`336`	`336`	`export function renderPrefetchLinks (ssrContext: SSRContext, rendererContext: RendererContext): string {`
`337`	`337`	`const { prefetch } = getRequestDependencies(ssrContext, rendererContext)`
`338`	`338`	`return Object.values(prefetch).map(({ path }) =>`
`339`		- `<link ${isModule(path) ? 'type="module" ' : ''}rel="prefetch" href="${rendererContext.publicPath}${path}">`
	`339`	+ `<link ${isModule(path) ? 'type="module" ' : ''}rel="prefetch${isCSS(path) ? ' stylesheet' : ''}" href="${rendererContext.publicPath}${path}">`
`340`	`340`	`).join('')`
`341`	`341`	`}`
`342`	`342`
Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ describe('renderer with legacy manifest', () => {`
`79`	`79`	const result = renderResourceHints().split('>').slice(0, -1).map(s => `${s}>`).sort()
`80`	`80`	`expect(result).to.deep.equal(`
`81`	`81`	`[`
`82`		`- '<link rel="prefetch" href="/_nuxt/pages/another.css">', // dynamic import CSS`
	`82`	`+ '<link rel="prefetch stylesheet" href="/_nuxt/pages/another.css">', // dynamic import CSS`
`83`	`83`	`'<link rel="prefetch" href="/_nuxt/pages/another.js">', // dynamic import`
`84`	`84`	`'<link rel="preload" href="/_nuxt/app.css" as="style">', // entrypoint CSS`
`85`	`85`	`'<link rel="preload" href="/_nuxt/app.js" as="script">',`