perf: sort ids before generating cache key (#42)

danielroe · web-flow · commit f2e13d5c19cd · 2022-10-14T17:58:55.000+02:00
diff --git a/src/runtime.ts b/src/runtime.ts
@@ -127,7 +127,7 @@ export function getModuleDependencies (id: string, rendererContext: RendererCont
 }
 
 export function getAllDependencies (ids: Set<string>, rendererContext: RendererContext): ModuleDependencies {
-  const cacheKey = Array.from(ids).join(',')
+  const cacheKey = Array.from(ids).sort().join(',')
   if (rendererContext._dependencySets[cacheKey]) {
     return rendererContext._dependencySets[cacheKey]
   }

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ export function getModuleDependencies (id: string, rendererContext: RendererCont`
`127`	`127`	`}`
`128`	`128`
`129`	`129`	`export function getAllDependencies (ids: Set<string>, rendererContext: RendererContext): ModuleDependencies {`
`130`		`- const cacheKey = Array.from(ids).join(',')`
	`130`	`+ const cacheKey = Array.from(ids).sort().join(',')`
`131`	`131`	`if (rendererContext._dependencySets[cacheKey]) {`
`132`	`132`	`return rendererContext._dependencySets[cacheKey]`
`133`	`133`	`}`