Skip to content

Commit 23400fc

Browse files
committed
feat: upgrade html-validator and use native hint links
1 parent 9f61ef1 commit 23400fc

File tree

4 files changed

+172
-175
lines changed

4 files changed

+172
-175
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
},
3030
"dependencies": {
3131
"defu": "3.2.2",
32-
"html-validate": "4.9.0"
32+
"html-validate": "4.10.0"
3333
},
3434
"devDependencies": {
3535
"@babel/plugin-transform-runtime": "7.13.15",
@@ -46,7 +46,7 @@
4646
"husky": "6.0.0",
4747
"jest": "26.6.3",
4848
"lint-staged": "10.5.4",
49-
"nuxt-edge": "2.16.0-26968342.9212d34e",
49+
"nuxt-edge": "2.16.0-26979859.88ea02c4",
5050
"release-it": "14.6.1",
5151
"siroc": "0.9.2"
5252
},

src/validator.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,7 @@ export const useChecker = (
5050
? await import('html-validate/dist/formatters/codeframe').then(r => r.default || /* istanbul ignore next */ r)
5151
: await import('html-validate/dist/formatters/stylish').then(r => r.default || /* istanbul ignore next */ r)
5252

53-
const rules = Array.from(new Set(results[0]?.messages.map(({ ruleId }) => ruleId)))
54-
55-
let formattedResult = formatter(results)
56-
rules.forEach((ruleId) => {
57-
formattedResult = formattedResult.replace(new RegExp(ruleId, 'g'), `https://html-validate.org/rules/${ruleId}.html`)
58-
})
53+
const formattedResult = formatter(results)
5954

6055
reporter.error(
6156
[

test/__snapshots__/validator.test.ts.snap

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ Array [
1313
"message": "Element <a> is not permitted as descendant of <a>",
1414
"offset": 41,
1515
"ruleId": "element-permitted-content",
16+
"ruleUrl": "https://html-validate.org/rules/element-permitted-content.html",
1617
"selector": "body > a > a",
1718
"severity": 2,
1819
"size": 1,

0 commit comments

Comments
 (0)