refactor: simplify additional messages

Author: danielroe

src/validator.ts

@@ -18,15 +18,19 @@ export const useValidator = (options: ConfigData = defaultOptions) => {
   return { validator }
 }
 
-export const useChecker = (validator: HtmlValidate, usePrettier = false, reporter = consola.withTag('html-validate')) => async (url: string, html: string) => {
+export const useChecker = (
+  validator: HtmlValidate,
+  usePrettier = false,
+  reporter = consola.withTag('html-validate')
+) => async (url: string, html: string) => {
   let couldFormat = false
   try {
     if (usePrettier) {
       const { format } = await import('prettier')
       html = format(html, { parser: 'html' })
       couldFormat = true
     }
-  // eslint-disable-next-line
+    // eslint-disable-next-line
   } catch (e) {
     reporter.error(e)
   }
@@ -38,7 +42,7 @@ export const useChecker = (validator: HtmlValidate, usePrettier = false, reporte
 
   if (valid) {
     return reporter.success(
-        `No HTML validation errors found for ${chalk.bold(url)}`
+      `No HTML validation errors found for ${chalk.bold(url)}`
     )
   }
 
@@ -48,22 +52,17 @@ export const useChecker = (validator: HtmlValidate, usePrettier = false, reporte
 
   const formattedResult = formatter(results)
 
-  let additionalInfo = ''
-
-  const messages = results[0].messages
-
-  messages.forEach(({ ruleId }: any) => {
-    const url = `https://html-validate.org/rules/${ruleId}.html`
-    additionalInfo = additionalInfo + url + '\n '
-  })
+  const urls =
+    results[0]?.messages.map(
+      ({ ruleId }: any) => `https://html-validate.org/rules/${ruleId}.html`
+    ) || []
 
   reporter.error(
+    [
       `HTML validation errors found for ${chalk.bold(url)}`,
-      '\n',
       formattedResult,
-      '\n',
-      `${chalk.bold('More information:')}`,
-      '\n',
-      additionalInfo
+      urls.length ? `${chalk.bold('More information:')}` : '',
+      ...urls
+    ].join('\n')
   )
 }

test/module.test.js

@@ -27,15 +27,24 @@ describe('Nuxt module', () => {
     const { body } = await get('/')
 
     expect(body).toContain('This is an invalid nested anchor tag')
-    expect(mockReporter.error).toHaveBeenCalledWith(expect.not.stringContaining('index.html'), expect.stringContaining('element-permitted-content'))
+    expect(mockReporter.error).toHaveBeenCalledWith(
+      expect.stringContaining('element-permitted-content')
+    )
   }, 50000)
 
   test('should add hook for generating HTML', async () => {
-    await generate('/')
+    await generate()
 
     const html = readFileSync(resolve(getNuxt().options.generate.dir, 'index.html'), 'utf8')
 
     expect(html).toContain('This is an invalid nested anchor tag')
-    expect(mockReporter.error).toHaveBeenCalledWith(expect.stringContaining('index.html'), expect.stringContaining('Element <a> is not permitted as descendant of <a>'))
+    expect(mockReporter.error).toHaveBeenCalledWith(
+      expect.stringContaining('index.html')
+    )
+    expect(mockReporter.error).toHaveBeenCalledWith(
+      expect.stringContaining(
+        'Element <a> is not permitted as descendant of <a>'
+      )
+    )
   }, 50000)
 })