chore: nuxt 4 compat

Author: harlan-zw

package.json

@@ -114,5 +114,10 @@
       "unrs-resolver",
       "vue-demi"
     ]
+  },
+  "resolutions": {
+    "@nuxt/kit": "npm:@nuxt/[email protected]",
+    "@nuxt/schema": "npm:@nuxt/[email protected]",
+    "nuxt": "npm:[email protected]"
   }
 }

pnpm-lock.yaml

@@ -528,10 +528,11 @@ export {}
 
     // only prerender for `nuxi generate`
     const isFirebase = nitroPreset === 'firebase'
-    if ((isNuxtGenerate() || (isFirebase && nuxt.options._build)) && config.robotsTxt) {
-      nuxt.options.generate = nuxt.options.generate || {}
-      nuxt.options.generate.routes = asArray(nuxt.options.generate.routes || [])
-      nuxt.options.generate.routes.push('/robots.txt')
+    // @ts-expected-error nuxt 3
+    if ((isNuxtGenerate() || isFirebase) && config.robotsTxt) {
+      nuxt.options.nitro.prerender = nuxt.options.nitro.prerender || {}
+      nuxt.options.nitro.prerender.routes = nuxt.options.nitro.prerender.routes || []
+      nuxt.options.nitro.prerender.routes.push('/robots.txt')
       if (isFirebase)
         logger.info('Firebase does not support dynamic robots.txt files. Prerendering /robots.txt.')
     }

src/module.ts

@@ -44,7 +44,6 @@ export default defineNitroPlugin(async (nitroApp: NitroApp) => {
       const isIsland = (process.env.NUXT_COMPONENT_ISLANDS && event.path.startsWith('/__nuxt_island'))
       const noSSR = !!(process.env.NUXT_NO_SSR)
         || event.context.nuxt?.noSSR
-        // @ts-expect-error upstream type issue
         || (routeOptions.ssr === false && !isIsland)
         || (import.meta.prerender ? PRERENDER_NO_SSR_ROUTES.has(event.path) : false)
       if (noSSR) {

src/runtime/server/plugins/initContext.ts

@@ -50,7 +50,8 @@ export function parseRobotsTxt(s: string): ParsedRobotsTxt {
   // read the contents
   for (const _line of s.split('\n')) {
     ln++
-    const [line] = _line.split('#').map(s => s.trim())
+    const [preComment] = _line.split('#').map(s => s.trim())
+    const line = String(preComment)
     const sepIndex = line.indexOf(':')
     // may not exist for comments
     if (sepIndex === -1)
@@ -151,15 +152,17 @@ function matches(pattern: string, path: string): boolean {
     }
 
     if (pattern[p] === '*') {
+      // @ts-expect-error untyped
       numMatchingLengths = pathLength - matchingLengths[0] + 1
       for (let i = 1; i < numMatchingLengths; i++) {
+        // @ts-expect-error untyped
         matchingLengths[i] = matchingLengths[i - 1] + 1
       }
     }
     else {
       let numMatches = 0
       for (let i = 0; i < numMatchingLengths; i++) {
-        const matchLength = matchingLengths[i]
+        const matchLength = matchingLengths[i] as number
         if (matchLength < pathLength && path[matchLength] === pattern[p]) {
           matchingLengths[numMatches++] = matchLength + 1
         }
@@ -182,7 +185,7 @@ export function matchPathToRule(path: string, _rules: Required<RobotsGroupResolv
   let i = 0
   while (i < rulesLength) {
     const rule = rules[i]
-    if (!matches(rule.pattern, path)) {
+    if (!rule || !matches(rule.pattern, path)) {
       i++
       continue
     }

src/util.ts

@@ -17,7 +17,7 @@ describe('bot detection', () => {
       headers: {
         'user-agent': 'Googlebot/2.1 (+http://www.google.com/bot.html)',
       },
-    })
+    }) as any
 
     expect(botResult.isBot).toBe(true)
     expect(botResult.botName).toBe('googlebot')
@@ -29,7 +29,7 @@ describe('bot detection', () => {
       headers: {
         'user-agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.124 Safari/537.36',
       },
-    })
+    }) as any
 
     expect(humanResult.isBot).toBe(false)
     expect(humanResult.botName).toBeUndefined()
@@ -53,7 +53,7 @@ describe('bot detection', () => {
 
   it('compares browser fingerprinting vs server-side detection', async () => {
     // Server-side detection (should not detect browser as bot)
-    const serverResult = await $fetch('/api/bot-detection')
+    const serverResult = await $fetch('/api/bot-detection') as any
     expect(serverResult.isBot).toBe(false)
 
     // Client-side fingerprinting (should detect automation)

test/e2e/bot-detection.test.ts

@@ -14,7 +14,8 @@ await setup({
 
 describe('default', () => {
   it('basic', async () => {
-    expect(await $fetch('/robots.txt')).toMatchInlineSnapshot(`
+    const robots = await $fetch('/robots.txt')
+    expect(robots).toMatchInlineSnapshot(`
       "# START nuxt-robots (indexable)
       User-agent: *
       Allow: /secret/exception

test/e2e/default.test.ts

@@ -38,6 +38,7 @@ await setup({
 
 describe('stack', () => {
   it('basic', async () => {
+    // @ts-expect-error untyped
     expect(await $fetch('/robots.txt')).toMatchInlineSnapshot(`
       "# START nuxt-robots (indexable)
       User-agent: Googlebot

test/e2e/groups.test.ts

@@ -38,6 +38,7 @@ describe('i18n', () => {
     `)
   })
   it('respects route rules', async () => {
+    // @ts-expect-error untyped
     expect((await $fetch('/en/route-rules/?mockProductionEnv=true')).match(/<meta name="robots" content="([^"]+)">/)[1]).toMatchInlineSnapshot(`"noindex, nofollow"`)
   })
 })

test/e2e/i18n.test.ts

@@ -4,35 +4,30 @@ import { describe, expect, it } from 'vitest'
 
 const { resolve } = createResolver(import.meta.url)
 
-process.env.NODE_ENV = 'production'
-await setup({
-  rootDir: resolve('../fixtures/basic'),
-  build: true,
-  nuxtConfig: {
-    site: {
-      env: 'staging', // staging blocks
-      url: 'https://example.com',
-    },
+describe('query override', async () => {
+  process.env.NODE_ENV = 'production'
+  await setup({
+    rootDir: resolve('../fixtures/basic'),
+    build: true,
+    nuxtConfig: {
+      site: {
+        env: 'staging', // staging blocks
+        url: 'https://example.com',
+      },
 
-    robots: {
-      debug: true,
+      robots: {
+        debug: true,
+      },
     },
-  },
-})
-
-describe('query override', () => {
+  })
   it('robots.txt', async () => {
     // blocked by default
     expect(await $fetch('/robots.txt')).toContain('(indexing disabled)')
     // but can be overridden
-    expect(await $fetch('/robots.txt', {
-      params: {
-        mockProductionEnv: true,
-      },
-    })).toContain('(indexable)')
+    expect(await $fetch('/robots.txt?mockProductionEnv=true')).toContain('(indexable)')
   })
   it('page', async () => {
     const homeResponse = await $fetch('/')
-    expect(homeResponse.match(/<meta name="robots" content="(.*)">/)?.[1]).toMatchInlineSnapshot(`"noindex, nofollow"`)
+    expect(homeResponse.match(/<meta name="robots" content="([^"]*)">/)?.[1]).toBe('noindex, nofollow')
   })
 })