ci: split size compare workflow into two

Author: danielroe

.github/workflows/size-comment.yml

@@ -0,0 +1,51 @@
+name: size-comment
+on:
+  workflow_run:
+    workflows: [size-build]
+    types: [completed]
+
+permissions:
+  pull-requests: write
+  issues: write
+  actions: read
+
+jobs:
+  comment:
+    # Only run if the build workflow succeeded and was triggered by a pull request
+    if: >
+      github.event.workflow_run.conclusion == 'success' &&
+      github.event.workflow_run.event == 'pull_request'
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        package: [nuxi, nuxt-cli, create-nuxt]
+    steps:
+      - name: 🔍 Get PR number
+        id: pr
+        uses: actions/github-script@v7
+        with:
+          script: |
+            const pulls = await github.rest.repos.listPullRequestsAssociatedWithCommit({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              commit_sha: context.payload.workflow_run.head_sha,
+            });
+            if (pulls.data.length > 0) {
+              return pulls.data[0].number;
+            }
+            
+      - name: ⏬ Download artifacts from workflow run
+        uses: actions/download-artifact@v4
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          run-id: ${{ github.event.workflow_run.id }}
+          
+      - name: 📊 Compare sizes
+        uses: twk3/[email protected]
+        env:
+          PR_NUMBER: ${{ steps.pr.outputs.result }}
+        with:
+          title: ${{ matrix.package }} size comparison
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          current-stats-json-path: ./head-stats/${{ matrix.package }}/stats.json
+          base-stats-json-path: ./base-stats/${{ matrix.package }}/stats.json

.github/workflows/size.yml

@@ -1,27 +1,21 @@
-name: size
+name: size-build
 on:
-  # this action will error unless run in a pr context
-  pull_request_target:
+  pull_request:
     branches:
       - main
 
 env:
   BUNDLE_SIZE: true
 
-permissions: {}
+permissions:
+  contents: read
 
 jobs:
   # Build current and upload stats.json
-  # You may replace this with your own build method. All that
-  # is required is that the stats.json be an artifact
   build-head:
     runs-on: ubuntu-latest
-    permissions:
-      contents: read
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
-        with:
-          ref: ${{ github.event.pull_request.head.sha }}
       - run: corepack enable
       - uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
         with:
@@ -40,12 +34,8 @@ jobs:
           path: ./packages/*/stats.json
 
   # Build base for comparison and upload stats.json
-  # You may replace this with your own build method. All that
-  # is required is that the stats.json be an artifact
   build-base:
     runs-on: ubuntu-latest
-    permissions:
-      contents: read
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
         with:
@@ -66,23 +56,3 @@ jobs:
         with:
           name: base-stats
           path: ./packages/*/stats.json
-
-  # run the action against the stats.json files
-  compare:
-    runs-on: ubuntu-latest
-    needs: [build-base, build-head]
-    permissions:
-      pull-requests: write
-      issues: write
-    strategy:
-      matrix:
-        package: [nuxi, nuxt-cli, create-nuxt]
-    steps:
-      - name: ⏬ Download stats.json
-        uses: actions/download-artifact@v5
-      - uses: twk3/[email protected]
-        with:
-          title: ${{ matrix.package }} size comparison
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          current-stats-json-path: ./head-stats/${{ matrix.package }}/stats.json
-          base-stats-json-path: ./base-stats/${{ matrix.package }}/stats.json