chore: broken type checking

harlan-zw · harlan-zw · commit 97a52188af36 · 2024-09-15T18:44:44.000+10:00
Fixes #260
diff --git a/src/runtime/components/ScriptGoogleMaps.vue b/src/runtime/components/ScriptGoogleMaps.vue
@@ -147,7 +147,9 @@ function resetMapMarkerMap(_marker: google.maps.marker.AdvancedMarkerElement | P
   })
 }
 
-async function createAdvancedMapMarker(_options: google.maps.marker.AdvancedMarkerElementOptions | `${string},${string}`) {
+async function createAdvancedMapMarker(_options?: google.maps.marker.AdvancedMarkerElementOptions | `${string},${string}`) {
+  if (!_options)
+    return
   const key = hash(_options)
   if (mapMarkers.value.has(key))
     return mapMarkers.value.get(key)
@@ -285,7 +287,6 @@ onMounted(() => {
       }
     }
     for (const k of toAdd) {
-      // @ts-expect-error broken
       createAdvancedMapMarker(nextMap.get(k))
     }
   }, {

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,9 @@ function resetMapMarkerMap(_marker: google.maps.marker.AdvancedMarkerElement \| P`
`147`	`147`	`})`
`148`	`148`	`}`
`149`	`149`
`150`		-async function createAdvancedMapMarker(_options: google.maps.marker.AdvancedMarkerElementOptions \| `${string},${string}`) {
	`150`	+async function createAdvancedMapMarker(_options?: google.maps.marker.AdvancedMarkerElementOptions \| `${string},${string}`) {
	`151`	`+ if (!_options)`
	`152`	`+ return`
`151`	`153`	`const key = hash(_options)`
`152`	`154`	`if (mapMarkers.value.has(key))`
`153`	`155`	`return mapMarkers.value.get(key)`
`@@ -285,7 +287,6 @@ onMounted(() => {`
`285`	`287`	`}`
`286`	`288`	`}`
`287`	`289`	`for (const k of toAdd) {`
`288`		`- // @ts-expect-error broken`
`289`	`290`	`createAdvancedMapMarker(nextMap.get(k))`
`290`	`291`	`}`
`291`	`292`	`}, {`