Skip to content

Commit 7133f50

Browse files
fix(components): broken types for update:model-value event (#4853)
Co-authored-by: Benjamin Canac <[email protected]>
1 parent 77b6b9a commit 7133f50

18 files changed

+32
-33
lines changed

src/runtime/components/Checkbox.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export interface CheckboxProps extends Pick<CheckboxRootProps, 'disabled' | 'req
4848
}
4949
5050
export type CheckboxEmits = {
51-
change: [payload: Event]
51+
change: [event: Event]
5252
}
5353
5454
export interface CheckboxSlots {

src/runtime/components/CheckboxGroup.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export interface CheckboxGroupProps<T extends CheckboxGroupItem = CheckboxGroupI
6060
}
6161
6262
export type CheckboxGroupEmits = CheckboxGroupRootEmits & {
63-
change: [payload: Event]
63+
change: [event: Event]
6464
}
6565
6666
type SlotProps<T extends CheckboxGroupItem> = (props: { item: T & { id: string } }) => any

src/runtime/components/Chip.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export interface ChipProps {
3535
}
3636
3737
export interface ChipEmits {
38-
'update:show': [payload: boolean]
38+
'update:show': [value: boolean]
3939
}
4040
4141
export interface ChipSlots {

src/runtime/components/ColorPicker.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ const props = withDefaults(defineProps<ColorPickerProps>(), {
8282
throttle: 50,
8383
defaultValue: '#FFFFFF'
8484
})
85+
8586
const modelValue = defineModel<string>(undefined)
8687
8788
const appConfig = useAppConfig() as ColorPicker['AppConfig']

src/runtime/components/FileUpload.vue

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,8 @@ export interface FileUploadProps<M extends boolean = false> {
9696
ui?: FileUpload['slots']
9797
}
9898
99-
export interface FileUploadEmits<M extends boolean = false> {
100-
'update:modelValue': [payload: M extends true ? File[] : File | null]
101-
'change': [event: Event]
99+
export interface FileUploadEmits {
100+
change: [event: Event]
102101
}
103102
104103
type FileUploadFiles<M> = (M extends true ? File[] : File) | null
@@ -146,7 +145,7 @@ const props = withDefaults(defineProps<FileUploadProps<M>>(), {
146145
layout: 'grid',
147146
position: 'outside'
148147
})
149-
const emits = defineEmits<FileUploadEmits<M>>()
148+
const emits = defineEmits<FileUploadEmits>()
150149
const slots = defineSlots<FileUploadSlots<M>>()
151150
152151
const modelValue = defineModel<(M extends true ? File[] : File) | null>()

src/runtime/components/Form.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ export interface FormProps<S extends FormSchema, T extends boolean = true> {
5454
}
5555
5656
export interface FormEmits<S extends FormSchema, T extends boolean = true> {
57-
submit: [payload: FormSubmitEvent<FormData<S, T>>]
58-
error: [payload: FormErrorEvent]
57+
submit: [event: FormSubmitEvent<FormData<S, T>>]
58+
error: [event: FormErrorEvent]
5959
}
6060
6161
export interface FormSlots {

src/runtime/components/Input.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export interface InputProps<T extends AcceptableValue = AcceptableValue> extends
5252
}
5353
5454
export interface InputEmits<T extends AcceptableValue = AcceptableValue> {
55-
'update:modelValue': [payload: T]
55+
'update:modelValue': [value: T]
5656
'blur': [event: FocusEvent]
5757
'change': [event: Event]
5858
}

src/runtime/components/InputMenu.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,9 +128,9 @@ export interface InputMenuProps<T extends ArrayOrNested<InputMenuItem> = ArrayOr
128128
}
129129
130130
export type InputMenuEmits<A extends ArrayOrNested<InputMenuItem>, VK extends GetItemKeys<A> | undefined, M extends boolean> = Pick<ComboboxRootEmits, 'update:open'> & {
131-
'change': [payload: Event]
132-
'blur': [payload: FocusEvent]
133-
'focus': [payload: FocusEvent]
131+
'change': [event: Event]
132+
'blur': [event: FocusEvent]
133+
'focus': [event: FocusEvent]
134134
'create': [item: string]
135135
/** Event handler when highlighted element changes. */
136136
'highlight': [payload: {

src/runtime/components/InputNumber.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,9 @@ export interface InputNumberProps extends Pick<NumberFieldRootProps, 'modelValue
6363
}
6464
6565
export interface InputNumberEmits {
66-
'update:modelValue': [payload: number]
66+
'update:modelValue': [value: number]
6767
'blur': [event: FocusEvent]
68-
'change': [payload: Event]
68+
'change': [event: Event]
6969
}
7070
7171
export interface InputNumberSlots {

src/runtime/components/PinInput.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ export interface PinInputProps<T extends PinInputType = 'text'> extends Pick<Pin
4141
}
4242
4343
export type PinInputEmits<T extends PinInputType = 'text'> = PinInputRootEmits<T> & {
44-
change: [payload: Event]
45-
blur: [payload: Event]
44+
change: [event: Event]
45+
blur: [event: Event]
4646
}
4747
4848
</script>

0 commit comments

Comments
 (0)