fix: enforce returning string for eval

atinux · atinux · commit 2ddefe5c212f · 2020-09-04T13:13:13.000+02:00
diff --git a/src/detectors.js b/src/detectors.js
@@ -88,7 +88,7 @@ async function match (detector, { originalHtml, html, scripts, page }) {
   // JS eval (for string value)
   if (detector.eval) {
     for (const js of asArray(detector.eval)) {
-      const value = await page.evaluate(js)
+      const value = await page.evaluate(`String(${js})`)
       if (value) return value
     }
     return null

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ async function match (detector, { originalHtml, html, scripts, page }) {`
`88`	`88`	`// JS eval (for string value)`
`89`	`89`	`if (detector.eval) {`
`90`	`90`	`for (const js of asArray(detector.eval)) {`
`91`		`- const value = await page.evaluate(js)`
	`91`	+ const value = await page.evaluate(`String(${js})`)
`92`	`92`	`if (value) return value`
`93`	`93`	`}`
`94`	`94`	`return null`