chore: improvements

Author: atinux

src/background.js

@@ -20,7 +20,7 @@ async function analyze (tabId, url) {
 
     store.commit('SET_SHOWCASE', data.body)
   }).catch((e) => {
-    store.commit('SET_SHOWCASE', e.response.data.statusCode === 400 ? 'noVue' : 'error')
+    store.commit('SET_SHOWCASE', e.response &&  e.response.data && e.response.data.statusCode === 400 ? 'noVue' : 'error')
   })
 }
 
@@ -58,7 +58,7 @@ async function detectVue (tabId, url) {
   if (!url) {
     return
   }
-  if (/^chrome/.test(url) || /^about/.test(url)) {
+  if (/^https:\/\//.test(url) === false) {
     return
   }
 
@@ -100,6 +100,6 @@ function resolveVue (tabId) {
       { greeting: '' }
     ).then((response) => {
       resolve(response)
-    })
+    }).catch((_) => {})
   })
 }

src/manifest.json

@@ -33,11 +33,9 @@
     ]
   },
   "permissions": [
-    "activeTab",
     "tabs",
     "background",
     "storage",
-    "http://*/*",
     "https://*/*"
   ]
-}
+}

src/popup/App.vue

@@ -111,6 +111,7 @@
         </div>
         <div v-else-if="state === 'error'">An error occurred</div>
         <div v-else-if="state === 'noVue'">Vue is not used on this website</div>
+        <div v-else-if="state === 'noData'">Vue Telemetry cannot analyze this url, only https domains are supported.</div>
       </div>
     </div>
   </div>
@@ -150,9 +151,10 @@ export default {
         return 'error'
       } else if (this.showcase && this.showcase !== 'noVue') {
         return 'data'
+      } else if (this.showcase) {
+        return 'noVue'
       }
-
-      return 'noVue'
+      return 'noData'
     }
   },
   methods: {

yarn.lock

@@ -859,7 +859,7 @@
   resolved "https://registry.yarnpkg.com/@types/mime-types/-/mime-types-2.1.0.tgz#9ca52cda363f699c69466c2a6ccdaad913ea7a73"
   integrity sha1-nKUs2jY/aZxpRmwqbM2q2RPqenM=
 
-"@types/node@*", "@types/node@^14.0.1":
+"@types/node@*":
   version "14.0.22"
   resolved "https://registry.yarnpkg.com/@types/node/-/node-14.0.22.tgz#23ea4d88189cec7d58f9e6b66f786b215eb61bdc"
   integrity sha512-emeGcJvdiZ4Z3ohbmw93E/64jRzUHAItSHt8nF7M4TGgQTiWqFVGB8KNpLGFmUHmHLvjvBgFwVlqNcq+VuGv9g==
@@ -2766,11 +2766,6 @@ es-to-primitive@^1.2.1:
     is-date-object "^1.0.1"
     is-symbol "^1.0.2"
 
-[email protected]:
-  version "1.1.0"
-  resolved "https://registry.yarnpkg.com/es6-object-assign/-/es6-object-assign-1.1.0.tgz#c2c3582656247c39ea107cb1e6652b6f9f24523c"
-  integrity sha1-wsNYJlYkfDnqEHyx5mUrb58kUjw=
-
 escalade@^3.0.1:
   version "3.0.1"
   resolved "https://registry.yarnpkg.com/escalade/-/escalade-3.0.1.tgz#52568a77443f6927cd0ab9c73129137533c965ed"
@@ -7155,19 +7150,11 @@ vue-template-es2015-compiler@^1.9.0:
   resolved "https://registry.yarnpkg.com/vue-template-es2015-compiler/-/vue-template-es2015-compiler-1.9.1.tgz#1ee3bc9a16ecbf5118be334bb15f9c46f82f5825"
   integrity sha512-4gDntzrifFnCEvyoO8PqyJDmguXgVPxKiIxrBKjIowvL9l+N66196+72XVYR8BBf1Uv1Fgt3bGevJ+sEmxfZzw==
 
-vue@2.6.11, vue@^2.6.10:
+vue@^2.6.10:
   version "2.6.11"
   resolved "https://registry.yarnpkg.com/vue/-/vue-2.6.11.tgz#76594d877d4b12234406e84e35275c6d514125c5"
   integrity sha512-VfPwgcGABbGAue9+sfrD4PuwFar7gPb1yl1UK1MwXoQPAw0BKSqWfoYCT/ThFrdEVWoI51dBuyCoiNU9bZDZxQ==
 
-[email protected]:
-  version "1.5.4"
-  resolved "https://registry.yarnpkg.com/vuejs-logger/-/vuejs-logger-1.5.4.tgz#c8bb12ed29ca90b8087144a44ad852d9bd170c6e"
-  integrity sha512-Bg4/HNodE83KD7HVdHFwgfAFuZdkqSqOA0G3WpN5+LWF2GKmZnl9qlM/hHZmjADaF8elxOLiFpQmu4hI3zn3JQ==
-  dependencies:
-    es6-object-assign "1.1.0"
-    vue "2.6.11"
-
 vuex-webextensions@^1.3.0:
   version "1.3.0"
   resolved "https://registry.yarnpkg.com/vuex-webextensions/-/vuex-webextensions-1.3.0.tgz#52a48490f61d65b0042f191201e848a47408b136"