chore: enhance CI/CD workflow with TypeScript typecheck and ESLint linting steps

Author: MatFillion

.github/workflows/ci-cd.yml

@@ -30,6 +30,12 @@ jobs:
       - name: Install dependencies
         run: npm install
 
+      - name: Typecheck
+        run: npm run typecheck
+
+      - name: Lint
+        run: npm run lint -- --max-warnings=0
+
       - name: Build the extension
         run: npm run compile
 

CHANGELOG.md

@@ -10,10 +10,10 @@ All notable changes to the "promptitude" extension will be documented in this fi
 
 - Dev tooling: Bumped TypeScript to 5.9.3 and @types/node to 20.19.23.
 - Pinned @types/vscode to ~1.70.0 to align with `engines.vscode: ^1.70.0` and avoid compiling against newer VS Code API types than we officially support.
- - Dev tooling: Upgraded ESLint to 9.x and @typescript-eslint (parser/plugin) to 8.x.
- - Migrated from legacy .eslintrc to ESLint v9 flat config (`eslint.config.cjs`).
- - Removed deprecated rule `@typescript-eslint/semi` and switched to core `semi`.
- - Removed legacy `.eslintrc.js` file to avoid confusion post-migration.
+- Dev tooling: Upgraded ESLint to 9.x and @typescript-eslint (parser/plugin) to 8.x.
+- Migrated from legacy .eslintrc to ESLint v9 flat config (`eslint.config.cjs`).
+- CI: Added ESLint lint step to CI/CD workflow to enforce lint on PRs/builds.
+- CI: Added a TypeScript typecheck step (tsc --noEmit) and made ESLint fail on warnings (--max-warnings=0).
 
 ### Security
 

package.json

@@ -128,7 +128,8 @@
     "compile": "tsc -p ./",
     "watch": "tsc -watch -p ./",
     "pretest": "npm run compile && npm run lint",
-    "lint": "eslint src --ext ts",
+    "lint": "eslint src",
+    "typecheck": "tsc -p ./ --noEmit",
     "test": "node ./out/test/runTest.js",
     "package": "vsce package"
   },